617639 - Hopefully useless null check in PresShell::SetIsActive for mDocument or [@ PresShell::UpdateImageLockingState | PresShell::SetIsActive]

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[timeless]

9242 PresShell::SetIsActive(PRBool aIsActive)
9243 {

9252   if (mDocument) {
9253     mDocument->EnumerateExternalResources(SetExternalResourceIsActive,
9254                                           &aIsActive);
9255   }

this will crash if !mDocument:
9256   return UpdateImageLockingState();
9257 }
9258 
9259 /*
9260  * Determines the current image locking state. Called when one of the
9261  * dependent factors changes.
9262  */
9263 nsresult
9264 PresShell::UpdateImageLockingState()
9265 {
9266   // We're locked if we're both thawed and active.
right here:
9267   return mDocument->SetImageLockingState(!mFrozen && mIsActive);

Comment 1

[Boris Zbarsky [:bzbarsky]]

I believe we never enter this code if !mDocument.

Comment 2

[timeless]

bz: this being different than bug 602516?

Comment 3

[timeless]

Attachment: patch

Comment 4

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 496372 [details] [diff] [review]
patch

Yes, this is different from Freeze().

Comment 5

[Dão Gottwald [:dao]]

http://hg.mozilla.org/mozilla-central/rev/bffd8632295e