617648 - Mainstream Newsletter signups - change default Country to United States, and cursor

Status: VERIFIED FIXED

(www.mozilla.org :: General, defect)

Description

[Eve Murto]

Two changes to make for the signup centers for the Mainstream Newsletter: 

1) Please change the default country to "United States" for all the EN-US signup centers for the Mainstream Newsletter: 

a) Landing Page
b) First Run page
c) What's New Page
d) Mozilla.org Home Page 

2) Please have the cursor immediately appear in the email address box (where they type in their email address) when they get to the signup page/box.  
 
thank you!  -Eve

Comment 1

[Alex Buchanan [:abuchanan]]

I'd just like to make clear that en-US does not necessarily mean United States.  I'm sure there are plenty of international users seeing the en-US pages, so I think this will make your data less accurate.

Comment 2

[Eve Murto]

Yes, thanks for the input.  We've discussed those tradeoffs internally and wish to move forward with placing United States as the default.   From analyzing the numbers, the vast majority of the signups are United States.   Thanks for your help to move this forward swiftly.   -Eve

Comment 3

[Jane Finette]

To make a clarifying comment here. We are suggesting that in the drop down the default country is United States -- however, someone make select a different country from that drop down. Isnt that correct Eve? thanks.

Comment 4

[Eve Murto]

Yes, exactly.  The default shows the United states, (rather than an instructional statement about selecting their country),  but they are free to scroll to any other country of their choice.  -Eve

Comment 5

[Alex Buchanan [:abuchanan]]

Attachment: patch v1

Comment 6

[Alex Buchanan [:abuchanan]]

I filed a separate bug for mozilla.org changes, bug 620511

Comment 7

[Anthony Ricaud (:rik)]

Comment on attachment 498833 [details] [diff] [review]
patch v1

I don't understand why you create autofocus.js. Can't you include that in newsletter/index.html directly? It's the only place that needs it (other than the form that already has its own JS).

Comment 8

[Alex Buchanan [:abuchanan]]

(In reply to comment #7)
> Comment on attachment 498833 [details] [diff] [review]
> patch v1
> 
> I don't understand why you create autofocus.js. Can't you include that in
> newsletter/index.html directly? It's the only place that needs it (other than
> the form that already has its own JS).

I made it separate because the code is generic and it's reusable that way.  Also, I try to avoid inline JS.

Comment 9

[Alex Buchanan [:abuchanan]]

Attachment: patch v2, include autofocus.js only on the needed page

Comment 10

[Anthony Ricaud (:rik)]

Comment on attachment 499360 [details] [diff] [review]
patch v2, include autofocus.js only on the needed page

Good.

If you want, you can drop 'type="text/javascript"' since it is not needed with HTML5.

Comment 11

[Alex Buchanan [:abuchanan]]

Thanks!

Committed to trunk,


Sending        en-US/newsletter/index.html
Sending        en-US/newsletter-form.html
Adding         js/autofocus.js
Sending        js/newsletter-form.js
Transmitting file data ....
Committed revision 79841.

Comment 12

[Alex Buchanan [:abuchanan]]

(In reply to comment #10)
> Comment on attachment 499360 [details] [diff] [review]
> patch v2, include autofocus.js only on the needed page
> 
> Good.
> 
> If you want, you can drop 'type="text/javascript"' since it is not needed with
> HTML5.

Ah, cool.  Also removed those on this page.

Comment 13

[Stephen Donner [:stephend] Not actively reading bugmail]

qa-verified-trunk:

http://www-trunk.stage.mozilla.com/en-US/newsletter/
http://www-trunk.stage.mozilla.com/en-US/firefox/connect/
https://www-trunk.stage.mozilla.com/en-US/firefox/3.6/firstrun/
https://www-trunk.stage.mozilla.com/en-US/firefox/3.6/whatsnew/ (just links to https://www-trunk.stage.mozilla.com/en-US/newsletter/)

Comment 14

[Alex Buchanan [:abuchanan]]

r79989 on production

Comment 15

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED on prod:

http://www.mozilla.com/en-US/newsletter/
http://www.mozilla.com/en-US/firefox/connect/
https://www.mozilla.com/en-US/firefox/3.6/firstrun/