Make arrow panels work in Modern

RESOLVED FIXED in seamonkey2.1b2

Status

SeaMonkey
Themes
RESOLVED FIXED
7 years ago
6 years ago

People

(Reporter: Robert Kaiser, Assigned: neil@parkwaycc.co.uk)

Tracking

(Blocks: 1 bug)

Trunk
seamonkey2.1b2
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Reporter)

Description

7 years ago
Bug 554937 implemented arrow panels, we need to support those in Modern as well.
(Assignee)

Comment 1

6 years ago
Created attachment 500548 [details] [diff] [review]
Proposed patch

This also turns doorhangers into arrow panels (Firefox bug 554937).
Assignee: nobody → neil
Status: NEW → ASSIGNED
Attachment #500548 - Flags: review?(stefanh)
(Assignee)

Comment 2

6 years ago
Created attachment 500623 [details] [diff] [review]
Drop popup support from Modern

As pointed out on IRC, Modern's popup support means that doorhanger notification options don't display properly. This fixes that.
Attachment #500623 - Flags: review?(stefanh)

Comment 3

6 years ago
Comment on attachment 500548 [details] [diff] [review]
Proposed patch

The menu button in the notification-popup looks a bit odd to me, but I guess that's how it should look? Otherwise we could add some notification-specific styling somehwhere (in another bug). I would add some margin to the .panel-inner-arrowcontent. But, as you said on irc - there doesn't seem to be any on windows either, so it's probably just me ;-)
Attachment #500548 - Flags: review?(stefanh) → review+

Updated

6 years ago
Attachment #500623 - Flags: review?(stefanh) → review+
(Assignee)

Comment 4

6 years ago
Comment on attachment 500548 [details] [diff] [review]
Proposed patch

>diff --git a/suite/browser/navigator.xul b/suite/browser/navigator.xul
>--- a/suite/browser/navigator.xul
>+++ b/suite/browser/navigator.xul
>@@ -152,39 +152,39 @@
My patch editing fu failed me. This should have been @@ -152,17 +152,17 @@
(Assignee)

Comment 5

6 years ago
Comment on attachment 500623 [details] [diff] [review]
Drop popup support from Modern

Pushed changeset 139af7ebc84d to comm-central.
(Assignee)

Comment 6

6 years ago
Pushed changeset ad7a388b7cd8 to comm-central.
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED

Updated

6 years ago
Target Milestone: --- → seamonkey2.1b2
Version: unspecified → Trunk

Updated

6 years ago
Blocks: 654005
You need to log in before you can comment on or make changes to this bug.