617661 - Make arrow panels work in Modern

Status: RESOLVED FIXED

(SeaMonkey :: Themes, defect)

Description

[Robert Kaiser]

Bug 554937 implemented arrow panels, we need to support those in Modern as well.

Comment 1

[[e-mail]]

Attachment: Proposed patch

This also turns doorhangers into arrow panels (Firefox bug 554937).

Comment 2

[[e-mail]]

Attachment: Drop popup support from Modern

As pointed out on IRC, Modern's popup support means that doorhanger notification options don't display properly. This fixes that.

Comment 3

[Stefan [:stefanh]]

Comment on attachment 500548 [details] [diff] [review]
Proposed patch

The menu button in the notification-popup looks a bit odd to me, but I guess that's how it should look? Otherwise we could add some notification-specific styling somehwhere (in another bug). I would add some margin to the .panel-inner-arrowcontent. But, as you said on irc - there doesn't seem to be any on windows either, so it's probably just me ;-)

Comment 4

[[e-mail]]

Comment on attachment 500548 [details] [diff] [review]
Proposed patch

>diff --git a/suite/browser/navigator.xul b/suite/browser/navigator.xul
>--- a/suite/browser/navigator.xul
>+++ b/suite/browser/navigator.xul
>@@ -152,39 +152,39 @@
My patch editing fu failed me. This should have been @@ -152,17 +152,17 @@

Comment 5

[[e-mail]]

Comment on attachment 500623 [details] [diff] [review]
Drop popup support from Modern

Pushed changeset 139af7ebc84d to comm-central.

Comment 6

[[e-mail]]

Pushed changeset ad7a388b7cd8 to comm-central.