617718 - Fennec crash [@ nsPresContext::IsRootContentDocument ] when loading GrooveShark (plugin.disable=false, dom.ipc.plugins.enabled=true)

Status: VERIFIED FIXED

(Core :: Layout, defect)

Description

[Daniel Holbert [:dholbert]]

STEPS TO REPRODUCE:
On a Nokia n900 with flashplayer installed:
 1. Set pref "plugin.disable" to false and "dom.ipc.plugins.enabled" to true, & restart Fennec.
(NOTE: If you don't set the second pref above, you'll hit Bug 617703 instead.)
 2. Visit http://listen.grooveshark.com
 3. Wait for a minute -- if you haven't crashed yet, try to interact with the page. (Search for a song, try to play it, etc.)

ACTUAL RESULTS: Crash [@ nsPresContext::IsRootContentDocument ]
Sample crash reports:
 bp-0520609d-0692-4e5e-90dd-04e172101208
 bp-e6263632-5147-4668-9218-30e262101208

Comment 1

[Boris Zbarsky [:bzbarsky]]

|vm| is null?

Comment 2

[Boris Zbarsky [:bzbarsky]]

Ah, yes.  We're under PresShell:Destroy, so it is.

We shouldn't be doing that invalidate during frame destruction, imho.

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: fix

Completely untested, but trivial fix.

Comment 4

[Daniel Holbert [:dholbert]]

Landed: http://hg.mozilla.org/mozilla-central/rev/6b98f6cf4589

Comment 5

[Daniel Holbert [:dholbert]]

I've verified that this no longer crashes, with the latest mozilla-central Fennec nightly on my n900.