Closed
Bug 617749
Opened 15 years ago
Closed 15 years ago
useless null check in nsSVGGlyphFrame::IsAbsolutelyPositioned
Categories
(Core :: SVG, defect)
Core
SVG
Tracking
()
RESOLVED
FIXED
mozilla2.0b12
People
(Reporter: timeless, Assigned: timeless)
References
(Blocks 1 open bug)
Details
(Keywords: coverity)
Attachments
(1 file)
|
677 bytes,
patch
|
jwatt
:
review+
dbaron
:
approval2.0+
|
Details | Diff | Splinter Review |
1289 nsSVGGlyphFrame::IsAbsolutelyPositioned()
1290 {
1291 PRBool hasTextPathAncestor = PR_FALSE;
1292 for (nsIFrame *frame = GetParent();
1293 frame != nsnull;
1294 frame = frame->GetParent()) {
1295
1296 if (!frame)
1297 break;
the for loop control prevents frame from being null at the start of the loop.
Assignee: nobody → timeless
Status: NEW → ASSIGNED
Attachment #496359 -
Flags: review?(jwatt)
Attachment #496359 -
Flags: approval2.0?
|
||
Updated•15 years ago
|
Attachment #496359 -
Flags: review?(jwatt) → review+
Attachment #496359 -
Flags: approval2.0? → approval2.0+
Keywords: checkin-needed
|
||
Comment 2•15 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b12
|
||
Updated•8 years ago
|
Blocks: coverity-analysis
You need to log in
before you can comment on or make changes to this bug.
Description
•