Closed Bug 617773 Opened 14 years ago Closed 13 years ago

Registration Page/Operations for about:add ons News

Categories

(www.mozilla.org :: General, defect)

Product:
www.mozilla.org
Component:
General
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: emurto, Assigned: jlong)

References

Details

Attachments

(1 file)

patch v1, missing copy and screenshot
1.02 KB, application/octet-stream
Details 
We have decided to keep the about:add ons newsletter going, so will need a registration page and flow of names into Responsys. 

Current newsletter signup for about:add ons has been in Developer Hub (addons.mozilla.org). Can't find it at the moment, perhaps we temporarily disabled it. 

Flow into Responsys into these fields:  
ABOUT_ADDONS_FLG
ABOUT_ADDONS_DATE 
Need country drop down list. 
Need click privacy policy. 
Email format:  HTML vs Text

Thank you! -Eve
I need a sub-heading paragraph and a screenshot of an example newsletter
Also, I need a success message paragraph.  For example, this one is from about:mozilla...

"""
Now you will be among the first to see Mozilla’s special events, product updates, videos and other awesomeness.
"""
Component: Email → www.mozilla.com
Product: Marketing → Websites
QA Contact: email → www-mozilla-com
Target Milestone: --- → 1.0
Looks like we're waiting on copy.
Assignee: nobody → fligtar
Assignee: fligtar → dhorner
Talked it over with Dan this morning - instead of a new landing page (form page) being constructed, what we need are some modifications to the existing sign-up box for this Add on Developer list. 
Current signup box is on this page: 
https://addons.mozilla.org/en-US/developers/community/newsletter
  
Here are the changes: 

-Headline: Change to "Subscribe to Quarterly News" (rather than "Subscribe by Email")
- Enter your email address to subscribe to our quarterly newsletter (change the word "monthly" to "quarterly") 
- Underneath that the Email signup box (with soft gray letters in it "Your Email Address"
- Underneath that: drop down menu for country 
- Underneath that: Email format o HTML  o Text  (small dial buttons) 
- (Check box) I agree to the Privacy Policy 
("Privacy Policy" is a link to our Mozilla privacy policy page) 
- Subscribe button (already there) 

Names to flow into Responsys (fields mentioned above) 

Thank you! 

Eve
Hey Morgamic - Now that Alex is gone (sniff, sniff) can you assign this to another web dev-er?
Assignee: dhorner → morgamic
We'll see -- we got copy the day before code freeze, so this may wait.
Assignee: morgamic → nobody
Target Milestone: 1.0 → 1.1
Assignee: nobody → jlong
I can do this -- where is the code for that page (where do I get the addons.mozilla.org project)?
(In reply to comment #8)
> I can do this -- where is the code for that page (where do I get the
> addons.mozilla.org project)?

This page is still in PHP (http://viewvc.svn.mozilla.org/vc/addons/trunk/) which makes it a daunting task to set up the dev server with little to no docs.  If you're more comfortable with python, this may be a good time to transition the page and save ourselves the work later.  (Writing the page in python is a lot more work than adjusting the page in PHP)
Python can eat PHP.  Lets convert it if the timeframe is reasonable.  How long do you think it would take me to convert, knowing that I'm very familiar with python/django but not with the addons project?
Zamboni (http://jbalogh.github.com/zamboni/) is going to be pretty familiar if you know django.  Setting it up should be relatively easy as you don't need any of the optional requirements like celeryd, etc.

For that particular page, stuff that stands out:

- I'm guessing you could have a "testo" page at that URL up and running in a few minutes
- Styles may or may not have been brought over from PHP (but nothing on that page is particularly pretty anyway).  We could probably use existing zamboni styles which would be consistent with other pages and look close to the same.
- Apparently "See all past issues" is a 404, but looks like we never maintained that anyway
- I don't know what "flow into Responsys" means but it looks like comment 5 is adding some new fields to the mix.  Is responsys handling/storing those for us?
- We use a library called bleach to print user content back on the page.  There are plenty of examples but get this r?'d by a developer

After writing all that out, I don't think it would take you long to do.  Probably less than a day.  You want the /devhub/ app, btw.
Moving to 1.2 since code freeze is today and the scope of this bug has increased due to possible code conversions.
Target Milestone: 1.1 → 1.2
I almost have zamboni up and running, and then I have to figure out how to port the page.  From what I see it won't take too long, but it's good for me to get to know another project anyway.
Status: NEW → ASSIGNED
I talked this over with some guys from amo (mainly Jeff) and we decided to leave this in PHP since most/all of the pages in this section aren't converted yet, and there is PHP code already to integrate Responsys.

If anyone objects, let me know. I'm off to see if I can get the PHP site basically running.
Just an update - I've decided to go back to the Python version since the PHP site will require a lot of work to setup and I'll have to learn some intricacies of the its framework anyway.  The responsys library is pretty simple too and it's probably worth starting a Python one for future projects.
I have ported everything over except the "country" field in the form.  I don't have a list of regions/country, and I can't just copy the list over because it's localized.  I could write a script to copy all of the localized regions over.

I do have a list of languages that is localized.  I'm assuming country is only used for locale, is there any way we can use the language name instead of country?
James, there is an existing standard list of countries we are using (in English) - you can see them in this drop down of this Mainstream Newsletter signup form, for example.  http://www.mozilla.com/en-US/newsletter/

We're adding in a country field into our standard newsletter signup forms wherever possible. 

cheers, Eve
The problem is that it's stuck in PHP land.  I've been working on a script to port them over to Python (and consequently throwing it into product-details).  The new addons site is completely separate from the PHP mozilla site, so this is taking a while.  It's worth it though because it needs to be done at some point.

So this will be done early next week, just need to keep filling in the holes to port everything over.
Depends on: 630308
I'm back on this bug, just fixed up the newsletter to work. I ended up exporting the region names into json, like other product details info, but embedded it into zamboni for now.

Comments are more than welcome, this is my first addition to a Mozilla django project. This commit implements the newsletter page:

https://github.com/jlongster/zamboni/commit/8577f87f6b4a4e7c9794c25113b9088cfe58c6be

This patch adds the region data (might be better somewhere else?):

https://github.com/jlongster/zamboni/commit/86eac0bcb339212a46eb038a29370078287accc5
I have not written tests for this yet, it looks like I should write them in the tests directory in the devhub app. I'll need to look at other tests and see how I hook it up.

Also, not sure how to r? officially for a git commit. Just the previous comment?
Eve or Winston,

This bug is dragging out because I'm not sure what to do with the "country" field which lists country names (or "regions"). These names are localized into about 30 languages.

Because we are porting this to addons, we need to translate the mozilla.com l10n data into the addons l10n structure which is a bit of work.

Is it worth localizing the region names? It looks like in the PHP code it's not even using the localizations, but only the English names:

http://svn.mozilla.org/projects/mozilla.com/tags/production/includes/regions.php

Notice when it calls `regionNames` doesn't pass in a locale and defaults to "en-US".
> Also, not sure how to r? officially for a git commit. Just the previous
> comment?

you can use the "pull requests" on github, or ask on irc or here.


> Is it worth localizing the region names?

Yes
> > Is it worth localizing the region names?
> 
> Yes

I need help then. I need to know how to integrate this data:

https://github.com/jlongster/zamboni/commit/86eac0bcb339212a46eb038a29370078287accc5

I don't really mean to shove it into the devhub app, that's just to get some review. Not really familiar with how this should be done.
Ok, everything has been r+ except for the localized region data.

I have moved it into the product-details library (a bunch of JSON files) and wrote a class to lazily load them.

https://github.com/jlongster/zamboni/commit/899927826ed6e1c91791801ef63441f3901f96d9

Review requested. The mozilla-product-details library (https://github.com/jbalogh/mozilla-product-details) will have to be updated. It's pretty old and my git-svn errors as if it's using an older repo format.
One thing which has not been discussed yet is the archives:

https://addons.mozilla.org/en-US/developers/community/newsletter

It looks way out date, so I bet it's broken. The new page doesn't list any recent articles and it has no way to track them. Does engagement expect to have a list somehow?
cancelled previous pull request, new commit in response to jbalogh's review:

https://github.com/jlongster/zamboni/commit/dca9d8c6e563e03d72160b13189daad59d184dbe
Target Milestone: 1.2 → 1.3
Someone on the addons team should take over this. I've done all the work but they can polish it up however they want (needs tests too).

https://github.com/jlongster/zamboni/commit/c5cc1a0894f56a441a24c951998e0d57bcd37ef0
Target Milestone: 1.3 → 1.4
(In reply to comment #30)
> Someone on the addons team should take over this. I've done all the work but
> they can polish it up however they want (needs tests too).
> 
> https://github.com/jlongster/zamboni/commit/c5cc1a0894f56a441a24c951998e0d57bcd37ef0

Fligtar - James has done a lot but it looks like it would be useful if AMO could take over from here. Thoughts?
Target Milestone: 1.4 → 1.5
(In reply to comment #31)
> (In reply to comment #30)
> > Someone on the addons team should take over this. I've done all the work but
> > they can polish it up however they want (needs tests too).
> > 
> > https://github.com/jlongster/zamboni/commit/c5cc1a0894f56a441a24c951998e0d57bcd37ef0
> 
> Fligtar - James has done a lot but it looks like it would be useful if AMO
> could take over from here. Thoughts?

I added a couple very minor comments to the patch last month.  It sounds like between those and the tests this was pretty much done.  James - why are you stopping halfway through the patch?
(In reply to comment #32)
> James - why are you stopping halfway through the patch?

Because for two weeks very minor comments kept coming in, and it became inefficient for me to keep pecking at it. I'm more than willing to finish it if those last comments and tests are all that need to be done.
(In reply to comment #33)
> (In reply to comment #32)
> > James - why are you stopping halfway through the patch?
> 
> Because for two weeks very minor comments kept coming in, and it became
> inefficient for me to keep pecking at it. I'm more than willing to finish it if
> those last comments and tests are all that need to be done.

Like I said in the comments, it needs to be looked at by jbalogh since I'm not sure if that's the right way to do escaping to the template.

AMO is strict about it's code quality because we've all seen how hard it is to maintain non standard code.  There are tools like `check.py` that you should be running to get rid of the nitpicks ahead of code review.
Ok, I finally fixed up the commit. jbalogh/clouserw, please review?

https://github.com/jlongster/zamboni/commit/ecbf89c91a1a497b7719ebc41899e8f59d02d2d8
Thanks James! 

https://github.com/jbalogh/zamboni/commit/3757da1 

I don't see any tests, so how do we know this works and that we don't break it in the future?

Can you file something like bug 614123 (but private) so that we can set the proper responsys ID?
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
(In reply to comment #36)
> I don't see any tests, so how do we know this works and that we don't break it
> in the future?

Shoot, I forgot to write tests, sorry. Need to get back in the habit of that. :) Will do that today.

> Can you file something like bug 614123 (but private) so that we can set the
> proper responsys ID?

Will do. Thanks!
I wrote some tests here. Reopening until these tests get in. Needs review:

https://github.com/jlongster/zamboni/commit/d93f509400eecd48ace6551065c7d86f8e1f446d
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Target Milestone: 1.5 → 2.1
https://github.com/jbalogh/zamboni/commit/36562f7
Status: REOPENED → RESOLVED
Closed: 13 years ago → 13 years ago
Resolution: --- → FIXED
Component: www.mozilla.org/firefox → www.mozilla.org
Component: www.mozilla.org → General
Product: Websites → www.mozilla.org
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: