617806 - Add CrossWeave target to Makefile

Status: RESOLVED FIXED

(Firefox :: Sync, defect)

Description

[Richard Newman [:rnewman]]

I have a sketch version of this in my tree. Will append when I get the chance.

Comment 1

[Richard Newman [:rnewman]]

Real short patch is in my clipboard, so forgive the lack of attachment:

diff --git a/Makefile b/Makefile
index f138d14..5d030c0 100644
--- a/Makefile
+++ b/Makefile
@@ -115,6 +115,11 @@ all: build
 
 .PHONY: setup build test xpi clean $(xpi_files)
 
+crossweave: xpi
+       pushd crossweave; \
+       python crossweave.py --binary /Applications/Firefox.app --xpi-path "$(xpi_dir)/$(xpi_name)" --manifest=test_manifest.txt; \
+       popd
+
 test: buildtests
        $(MAKE) -k -C services/crypto/tests/unit
        $(MAKE) -k -C services/sync/tests/unit



Of course, depends on a "crossweave" checkout in fx-sync, which is how both Philipp and I do things.

Comment 2

[Richard Newman [:rnewman]]

Attachment: Add target to makefile.

Might as well do this properly.

Comment 3

[Philipp von Weitershausen [:philikon]]

Comment on attachment 498183 [details] [diff] [review]
Add target to makefile.

Sweet!

>+crossweave: xpi
>+	pushd crossweave; \
>+	python crossweave.py --binary /Applications/Firefox.app --xpi-path "$(xpi_dir)/$(xpi_name)" --manifest=test_manifest.txt; \

Can we make --binary configurable through an env var? Because it's definitely not that on my system, and you might want to run crossweave against different versions of Firefox as well.

Also please wrap the long line  if you want to make me extra happy ;)

Comment 4

[Richard Newman [:rnewman]]

Tidied up and pushed:

http://hg.mozilla.org/services/fx-sync/rev/e40861c0b26c

CROSSWEAVE_FF_BIN is the environment var. (Couldn't use e.g., XULRUNNER_BIN -- not the same kind of path.)