617827 - Long comments overflow box on themes page

Status: VERIFIED FIXED

(Input :: General, defect)

Description

[Fred Wenzel [:wenzel]]

Looooong comments in themes break out of their box (see attachment).

Example text:
"# it crashes when i play a game FIX IT IT IS UNSTABLE BOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOO"

(also, the last time I did this, the same bug showed up on bugzilla, and my bug about it was wontfixed ;))

We can probably just add overflow:hidden there. Such long comments are unlikely to be legitimate.

Comment 1

[Fred Wenzel [:wenzel]]

Attachment: Screenshot

Comment 2

[Stephen Donner [:stephend] Not actively reading bugmail]

Or we could ellipsize, "BOOOO..." and display the full text in its ALT/TITLE attributes.

Comment 3

[Aakash Desai [:aakashd]]

The messages are short enough that they won't go past two lines. I don't think they're long enough to constitute an ellipse from the point of view of a reader...especially if that reader is trying to skim through a bunch of messages. My preferred approach is just using overflow:hidden.

Comment 4

[Dave Dash [:davedash, :dd] (assign all bugs to mbrandt)]

We just hired a guy who knows about computerized style sheets.

Comment 5

[tofumatt [:tofumatt]]

We can use word-wrap: break-word to wrap it if browsers support it (and most do: https://developer.mozilla.org/En/CSS/Word-wrap).

overflow: hidden is there as a fallback, so wrapping never happens.

https://github.com/fwenzel/reporter/commit/d3c2b89a1ab4307177ad2c93c2bc13e955da139f

Comment 6

[Matt Brandt [:mbrandt]]

QA verified on stage :) The following wraps as expected in Firefox, Opera, IE9.

"Mean QAs! BOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOO"