Long comments overflow box on themes page

VERIFIED FIXED in 4.0

Status

Input
General
--
trivial
VERIFIED FIXED
8 years ago
7 years ago

People

(Reporter: wenzel, Assigned: tofumatt)

Tracking

Details

Attachments

(1 attachment)

(Reporter)

Description

8 years ago
Looooong comments in themes break out of their box (see attachment).

Example text:
"# it crashes when i play a game FIX IT IT IS UNSTABLE BOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOO"

(also, the last time I did this, the same bug showed up on bugzilla, and my bug about it was wontfixed ;))

We can probably just add overflow:hidden there. Such long comments are unlikely to be legitimate.
(Reporter)

Comment 1

8 years ago
Created attachment 496376 [details]
Screenshot
Or we could ellipsize, "BOOOO..." and display the full text in its ALT/TITLE attributes.
The messages are short enough that they won't go past two lines. I don't think they're long enough to constitute an ellipse from the point of view of a reader...especially if that reader is trying to skim through a bunch of messages. My preferred approach is just using overflow:hidden.
We just hired a guy who knows about computerized style sheets.
Assignee: nobody → mmacpherson
(Assignee)

Comment 5

7 years ago
We can use word-wrap: break-word to wrap it if browsers support it (and most do: https://developer.mozilla.org/En/CSS/Word-wrap).

overflow: hidden is there as a fallback, so wrapping never happens.

https://github.com/fwenzel/reporter/commit/d3c2b89a1ab4307177ad2c93c2bc13e955da139f
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
(Assignee)

Updated

7 years ago
Target Milestone: --- → 4.0
QA verified on stage :) The following wraps as expected in Firefox, Opera, IE9.

"Mean QAs! BOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOO"
Status: RESOLVED → VERIFIED
Component: Input → General
Product: Webtools → Input
You need to log in before you can comment on or make changes to this bug.