Closed Bug 617838 Opened 9 years ago Closed 9 years ago

javascript: URIs don't work in <browser remote>

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: cjones, Assigned: cjones)

References

Details

Attachments

(2 files)

STR
 (1) Run
firefox -no-remote -chrome chrome://global/content/test-ipcbrowser.xul
 (2) Load http://people.mozilla.com/~cjones/jsuri.html

Two frames with the text "frame1" and "frame2" should appear.  Instead, the frames are blank and this assertion appears twice on stderr

###!!! ASSERTION: Trying to initialize PSM/NSS in a non-chrome process!: 'Error', file /home/cjones/mozilla/mozilla-central/security/manager/ssl/src/nsNSSComponent.cpp, line 307

This works in fennec, for reasons unknown.

I recall jdm wrestling with this for data: URIs a while back.  data: URIs indeed do work in <browser remote>.
Component: General → DOM
QA Contact: general → general
"totally guaranteed safe fix" per IRC discussion.  Not sure I did this in the right place.  I see call in this file to mStreamChannel->Open(), which would presumably need a similar fix if it pops up.
Assignee: nobody → jones.chris.g
Attachment #496403 - Flags: review?(bzbarsky)
Comment on attachment 496403 [details] [diff] [review]
Don't run the URI classifier on javascript: URIs

I think it would be safer to just mask this out of aLoadFlags at the top of nsJSChannel::SetLoadFlags.  That would make sure that if someone calls GetLoadFlags then SetLoadFlags on us in various places the right things still happen.
Attachment #496403 - Flags: review?(bzbarsky) → review+
Carrying over r+.

Requesting approval because this blocks bug 615386 currently, and would require ugly workarounds to unblock.
Attachment #496404 - Flags: review+
Attachment #496404 - Flags: approval2.0?
Attachment #496404 - Flags: approval2.0? → approval2.0+
http://hg.mozilla.org/mozilla-central/rev/d3e7baf00c96
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.