617897 - Replace calls to AppendASCII('*') with Append('*')

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Alfred Kayser]

In mozilla/ xpcom/ io/ nsLocalFileWin.cpp  there are calls to AppendASCII which should be replaced by AppendLiteral, and for the case of one character with just Append('*') or Append('\\'); 
This prevent the need for a string, strlen, strcpy, etc.

Comment 1

[Alfred Kayser]

http://mxr.mozilla.org/mozilla-central/search?string=AppendASCII%28%22&find=&findi=&filter=^[^\0]*%24&hitlimit=&tree=mozilla-central

The difference between AppendASCII("...") and AppendLiteral("...") is that the first also a does a "strlen" on the argument, whilst the second uses the compiler to pass the string length.

Comment 2

[David Teller [:Yoric] - still alive but not very active]

I can mentor that.

Comment 3

[Iivari Äikäs [:orva]]

Attachment: patch

Simple patch, test cases left untouched. As this is my "low hanging fruit" to get familiar with Mozilla development process, all criticism is more than welcome.

Comment 4

[Alfred Kayser]

This looks good to me!

Nit:
In nsLocalFileWin.cpp, I would replace:
738     if (filename.Last() == L'/' || filename.Last() == L'\\')
739         filename.AppendASCII("*");
740     else 
741         filename.AppendASCII("\\*");
742 
743     filename.ReplaceChar(L'/', L'\\');

with:
     filename.ReplaceChar(L'/', L'\\');
     if (filename.Last() != L'\\') filename.Append('\\');
     filename.Append('*');

But that is probably best for another bug.

Comment 5

[David Teller [:Yoric] - still alive but not very active]

Comment on attachment 745201 [details] [diff] [review]
patch

Review of attachment 745201 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me, too.
Passing to someone who has review rights on that directory.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/865b9be24831

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/865b9be24831