617953 - Hunspell::analyze leaks p = pSMgr->suggest_morph()

Status: RESOLVED FIXED

(Core :: Spelling checker, defect)

Description

[timeless]

1379 int Hunspell::analyze(char*** slst, const char * word)
1380 {

1530         if (spell(cw)) {
1531                 char * p = pSMgr->suggest_morph(cw);
1532                 if (p) return line_tok(pSMgr->suggest_morph(cw), slst, MSEP_REC);
1533         }

line 1532 should be passing p instead of calling the same function again

Comment 1

[Caolan McNamara]

Attachment: here's what I'll check in upstream for this

Comment 2

[Jonathan Watt [:jwatt]]

Pushed http://hg.mozilla.org/mozilla-central/rev/6a05c245907e

Comment 3

[(no longer active)]

I think you need to request branch approval, Ryan, if you want this on 1.9.2.

Comment 4

[Ryan VanderMeulen [:RyanVM]]

Not sure if it's worth taking on 1.9.2 or not. I figured I'd ask approval if the drivers want to take these fixes.

We obviously need to take the topcrash fix, though.