Hunspell::analyze leaks p = pSMgr->suggest_morph()

RESOLVED FIXED

Status

()

Core
Spelling checker
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: timeless, Assigned: Caolan McNamara)

Tracking

({coverity, memory-leak})

Trunk
x86
Mac OS X
coverity, memory-leak
Points:
---

Firefox Tracking Flags

(status1.9.2 ?)

Details

(Whiteboard: [fixed-in-hunspell-1.2.13], URL)

Attachments

(1 attachment)

(Reporter)

Description

8 years ago
1379 int Hunspell::analyze(char*** slst, const char * word)
1380 {

1530         if (spell(cw)) {
1531                 char * p = pSMgr->suggest_morph(cw);
1532                 if (p) return line_tok(pSMgr->suggest_morph(cw), slst, MSEP_REC);
1533         }

line 1532 should be passing p instead of calling the same function again
(Assignee)

Comment 1

8 years ago
Created attachment 496559 [details] [diff] [review]
here's what I'll check in upstream for this
(Reporter)

Updated

8 years ago
Attachment #496559 - Flags: review+
Whiteboard: [fixed-in-hunspell-1.2.13]
Depends on: 620626
Attachment #496559 - Flags: approval2.0?
Whiteboard: [fixed-in-hunspell-1.2.13] → [fixed-in-hunspell-1.2.13][needs landing]
Keywords: 4xp, checkin-needed
Keywords: 4xp
Pushed http://hg.mozilla.org/mozilla-central/rev/6a05c245907e
Assignee: nobody → caolanm
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
status1.9.2: --- → ?
Whiteboard: [fixed-in-hunspell-1.2.13][needs landing] → [fixed-in-hunspell-1.2.13]
I think you need to request branch approval, Ryan, if you want this on 1.9.2.
Not sure if it's worth taking on 1.9.2 or not. I figured I'd ask approval if the drivers want to take these fixes.

We obviously need to take the topcrash fix, though.
You need to log in before you can comment on or make changes to this bug.