618017 - Parsing XML can override the version

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Chris Leary [:cdleary] (not checking bugmail)]

Attachment: POC failure.

When an XML element or list root is encountered in the parser it sets JSOPTION_XML for the scope of that parse node to indicate that the scanner should scan |<!--| and |<![CDATA[| as tokens.

The parser currently sets JSOPTION_XML to indicate this, knowing that it'll get propagated to the version, and that the scanner will look at the version. Given that this is a scoped set/unset, we can just set a mode bit on the scanner and avoid the version override.

Comment 1

[Chris Leary [:cdleary] (not checking bugmail)]

Confirmed that this is fixed by the patch queue in bug 595691, just gotta make a test case patch!

Comment 2

[Chris Leary [:cdleary] (not checking bugmail)]

Attachment: Mochitest.

Mochitest seems most appropriate given that we want to test exactly this browser-level behavior.

Comment 3

[Chris Leary [:cdleary] (not checking bugmail)]

Comment on attachment 506324 [details] [diff] [review]
Mochitest.

Confirmed passing on my machine on top of the patch queue dependency.

Comment 4

[Chris Leary [:cdleary] (not checking bugmail)]

http://hg.mozilla.org/tracemonkey/rev/1537ab211532

Comment 5

[Chris Leary [:cdleary] (not checking bugmail)]

cdleary-bot mozilla-central merge info:
http://hg.mozilla.org/mozilla-central/rev/1537ab211532