Closed Bug 618124 Opened 9 years ago Closed 9 years ago

Pause button shows when video goes full screen

Categories

(Firefox for Android Graveyard :: General, defect)

defect
Not set

Tracking

(fennec2.0+)

VERIFIED FIXED
Tracking Status
fennec 2.0+ ---

People

(Reporter: wesj, Assigned: wesj)

Details

(Keywords: polish, Whiteboard: [fennec-checkin-postb3])

Attachments

(1 file)

When you open up a video in fullscreen the pause control is shown. Tapping on it (to pause) and then starting the video again, the controls disappear.

STR:
1.) Open an html5 video using our controls (http://people.mozilla.com/~mfinkle/tutorials)
2.) Long tap
3.) Open fullscreen
tracking-fennec: --- → ?
Assignee: nobody → wjohnston
tracking-fennec: ? → 2.0+
Keywords: polish
Attached patch Hacky PatchSplinter Review
This is a very hacky way of doing this.

The problem here is that we are starting the video using video.play(), which doesn't cause the controls to hide (they are only hidden by clicking on the play button). Not a lot of great use cases I can think of for web sites to leave our controls visible and also control the video dynamically.

However we can alternatively set the autoplay attribute on the video. If you use autoplay, we run into a separate bug. Namely, the first click fired on the video (presumably to show the controls) also fires a mouseover on the video via EventStateManager:

http://mxr.mozilla.org/mozilla-central/source/content/events/src/nsEventStateManager.cpp#3772

The mouseover shows the controls, and when the mouseup is fired, it sees that they are showing (in transition) and hides them. So we need some method to know that even though the controls are hidden=false they are not showing yet. As far as I know, the least disruptive means of doing that (i.e. not messing with the main firefox video control bindings) is listening to transitionend events? I played with that for a bit, and kept running into situations where the controls would not appear or would disappear under the wrong circumstances.

The hacky approach just fires the initial mouseover and click on the video element itself rather than calling video.play().
Attachment #497630 - Flags: review?(mark.finkle)
Comment on attachment 497630 [details] [diff] [review]
Hacky Patch

nit: Use 'let' not 'var'
Attachment #497630 - Flags: review?(mark.finkle) → review+
Whiteboard: [fennec-checkin-postb3]
Pushed:

http://hg.mozilla.org/mobile-browser/rev/a2f974f5cbd9
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Verified fixed testing on Mozilla/5.0 (Android; Linux armv7l; rv:2.0b10pre) Gecko/20110112 Firefox/4.0b10pre Fennec/4.0b4pre
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.