618135 - IndexedDB: Implement update() on index cursors (not on index key cursors)

Status: RESOLVED FIXED

(Core :: Storage: IndexedDB, defect)

Description

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Need to implement update() on index cursors.

Comment 1

[Johnny Stenback (:jst)]

This is part of the last set of bugs we've deemed necessary in order to ship 2.0, blocking beta9.

Comment 2

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Attachment: Patch, v1

Comment 3

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Attachment: Patch, v1

Oops, this is the right patch.

Comment 4

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Comment on attachment 497227 [details] [diff] [review]
Patch, v1

> IDBCursor::Update(const jsval& aValue,
...
>+#ifdef DEBUG
>+  NS_ASSERTION(mObjectStore, "This cannot be null!");
>+  NS_ASSERTION(!mKey.IsUnset() , "Bad key!");
>+
>+  if (mType == INDEXOBJECT) {
>+    NS_ASSERTION(!mObjectKey.IsUnset(), "Bad key!");
>+  }
>+#endif

Change the last assertion to

NS_ASSERTION(mType != INDEXOBJECT || !mObjectKey.IsUnset(), "Bad key!");

and remove the #ifdef

r=me with that

Comment 5

[Ben Turner (not reading bugmail, use the needinfo flag!)]

http://hg.mozilla.org/mozilla-central/rev/6fc66fc1193c

Comment 6

[LegNeato]

As per today's meeting, beta 9 will be a time-based release. Marking these all betaN+. Please move it back to beta9+ if  you believe it MUST be in the next beta (ie: trunk is in an unshippable state without this)