Closed Bug 618135 Opened 9 years ago Closed 9 years ago

IndexedDB: Implement update() on index cursors (not on index key cursors)

Categories

(Core :: Storage: IndexedDB, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
Tracking Status
blocking2.0 --- betaN+

People

(Reporter: bent.mozilla, Assigned: bent.mozilla)

Details

Attachments

(1 file, 1 obsolete file)

Need to implement update() on index cursors.
This is part of the last set of bugs we've deemed necessary in order to ship 2.0, blocking beta9.
blocking2.0: ? → beta9+
Attached patch Patch, v1 (obsolete) — Splinter Review
Attachment #497226 - Flags: review?(jonas)
Attached patch Patch, v1Splinter Review
Oops, this is the right patch.
Attachment #497226 - Attachment is obsolete: true
Attachment #497227 - Flags: review?(jonas)
Attachment #497226 - Flags: review?(jonas)
Comment on attachment 497227 [details] [diff] [review]
Patch, v1

> IDBCursor::Update(const jsval& aValue,
...
>+#ifdef DEBUG
>+  NS_ASSERTION(mObjectStore, "This cannot be null!");
>+  NS_ASSERTION(!mKey.IsUnset() , "Bad key!");
>+
>+  if (mType == INDEXOBJECT) {
>+    NS_ASSERTION(!mObjectKey.IsUnset(), "Bad key!");
>+  }
>+#endif

Change the last assertion to

NS_ASSERTION(mType != INDEXOBJECT || !mObjectKey.IsUnset(), "Bad key!");

and remove the #ifdef

r=me with that
Attachment #497227 - Flags: review?(jonas) → review+
http://hg.mozilla.org/mozilla-central/rev/6fc66fc1193c
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
As per today's meeting, beta 9 will be a time-based release. Marking these all betaN+. Please move it back to beta9+ if  you believe it MUST be in the next beta (ie: trunk is in an unshippable state without this)
blocking2.0: beta9+ → betaN+
Component: DOM → DOM: IndexedDB
Version: Trunk → unspecified
You need to log in before you can comment on or make changes to this bug.