618143 - IndexedDB: Don't accept null as a valid key

Status: RESOLVED FIXED

(Core :: Storage: IndexedDB, defect)

Description

[Ben Turner (not reading bugmail, use the needinfo flag!)]

The spec no longer allows null as a valid key.

Comment 1

[Johnny Stenback (:jst)]

This is part of the last set of IndexedDB bugs we've deemed necessary in order to ship 2.0, blocking beta9.

Comment 2

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Attachment: Patch, v1

Comment 3

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Comment on attachment 497095 [details] [diff] [review]
Patch, v1

Change all

if (NS_FAILED(rv)) {
  return rv;
}

to

NS_ENSURE_SUCCESS(rv, rv);

The latter clutters up the code much less.

Comment 4

[Ben Turner (not reading bugmail, use the needinfo flag!)]

http://hg.mozilla.org/mozilla-central/rev/5d1671710f9e

Comment 5

[LegNeato]

As per today's meeting, beta 9 will be a time-based release. Marking these all betaN+. Please move it back to beta9+ if  you believe it MUST be in the next beta (ie: trunk is in an unshippable state without this)