Closed Bug 618143 Opened 9 years ago Closed 9 years ago

IndexedDB: Don't accept null as a valid key

Categories

(Core :: DOM: IndexedDB, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
Tracking Status
blocking2.0 --- betaN+

People

(Reporter: bent.mozilla, Assigned: bent.mozilla)

Details

Attachments

(1 file)

The spec no longer allows null as a valid key.
This is part of the last set of IndexedDB bugs we've deemed necessary in order to ship 2.0, blocking beta9.
blocking2.0: ? → beta9+
Comment on attachment 497095 [details] [diff] [review]
Patch, v1

Change all

if (NS_FAILED(rv)) {
  return rv;
}

to

NS_ENSURE_SUCCESS(rv, rv);

The latter clutters up the code much less.
Attachment #497095 - Flags: review?(jonas) → review+
http://hg.mozilla.org/mozilla-central/rev/5d1671710f9e
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
As per today's meeting, beta 9 will be a time-based release. Marking these all betaN+. Please move it back to beta9+ if  you believe it MUST be in the next beta (ie: trunk is in an unshippable state without this)
blocking2.0: beta9+ → betaN+
Component: DOM → DOM: IndexedDB
Version: Trunk → unspecified
You need to log in before you can comment on or make changes to this bug.