Closed
Bug 618160
Opened 14 years ago
Closed 14 years ago
Don't show progress dialog in crash reporter if a report isn't being sent
Categories
(Core Graveyard :: Widget: Android, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: mwu, Assigned: mwu)
Details
(Keywords: polish)
Attachments
(1 file, 2 obsolete files)
|
1.70 KB,
patch
|
blassey
:
review+
blassey
:
approval2.0+
|
Details | Diff | Splinter Review |
The progress dialog popping up when the crash report isn't actually sent looks weird.
Attachment #496673 -
Flags: review?(blassey.bugs)
|
Assignee | |
Comment 1•14 years ago
|
||
Left a show() in by mistake.
Attachment #496673 -
Attachment is obsolete: true
Attachment #496674 -
Flags: review?(blassey.bugs)
Attachment #496673 -
Flags: review?(blassey.bugs)
|
|
Assignee | |
Comment 2•14 years ago
|
||
Last one, for real. Apparently finish() returns.
Attachment #496674 -
Attachment is obsolete: true
Attachment #496678 -
Flags: review?(blassey.bugs)
Attachment #496674 -
Flags: review?(blassey.bugs)
|
||
Comment 3•14 years ago
|
||
Comment on attachment 496673 [details] [diff] [review] Fix It this patch doesn't do what the summary says. If you un-select the send report option and click close, we still show the progress dialog. Is that intentional?
|
|
Assignee | |
Comment 4•14 years ago
|
||
(In reply to comment #3) > Comment on attachment 496673 [details] [diff] [review] > Fix > > It this patch doesn't do what the summary says. If you un-select the send > report option and click close, we still show the progress dialog. Is that > intentional? That's what v3 fixes.
|
|
||
Updated•14 years ago
|
Attachment #496678 -
Flags: review?(blassey.bugs) → review+
|
|
Assignee | |
Updated•14 years ago
|
Attachment #496678 -
Flags: approval2.0?
|
|
||
Updated•14 years ago
|
Attachment #496678 -
Flags: approval2.0? → approval2.0+
|
|
Assignee | |
Comment 5•14 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/e7e21099545f
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
|
||
Updated•3 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•