Closed Bug 618160 Opened 9 years ago Closed 9 years ago

Don't show progress dialog in crash reporter if a report isn't being sent

Categories

(Core :: Widget: Android, defect)

All
Android
defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: mwu, Assigned: mwu)

Details

(Keywords: polish)

Attachments

(1 file, 2 obsolete files)

Attached patch Fix (obsolete) — Splinter Review
The progress dialog popping up when the crash report isn't actually sent looks weird.
Attachment #496673 - Flags: review?(blassey.bugs)
Attached patch Fix, v2 (obsolete) — Splinter Review
Left a show() in by mistake.
Attachment #496673 - Attachment is obsolete: true
Attachment #496674 - Flags: review?(blassey.bugs)
Attachment #496673 - Flags: review?(blassey.bugs)
Attached patch Fix, v3Splinter Review
Last one, for real. Apparently finish() returns.
Attachment #496674 - Attachment is obsolete: true
Attachment #496678 - Flags: review?(blassey.bugs)
Attachment #496674 - Flags: review?(blassey.bugs)
Comment on attachment 496673 [details] [diff] [review]
Fix

It this patch doesn't do what the summary says. If you un-select the send report option and click close, we still show the progress dialog. Is that intentional?
(In reply to comment #3)
> Comment on attachment 496673 [details] [diff] [review]
> Fix
> 
> It this patch doesn't do what the summary says. If you un-select the send
> report option and click close, we still show the progress dialog. Is that
> intentional?

That's what v3 fixes.
Attachment #496678 - Flags: review?(blassey.bugs) → review+
Attachment #496678 - Flags: approval2.0?
Attachment #496678 - Flags: approval2.0? → approval2.0+
http://hg.mozilla.org/mozilla-central/rev/e7e21099545f
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.