618160 - Don't show progress dialog in crash reporter if a report isn't being sent

Status: RESOLVED FIXED

(Core Graveyard :: Widget: Android, defect)

Description

[Michael Wu [:mwu]]

Attachment: Fix

The progress dialog popping up when the crash report isn't actually sent looks weird.

Comment 1

[Michael Wu [:mwu]]

Attachment: Fix, v2

Left a show() in by mistake.

Comment 2

[Michael Wu [:mwu]]

Attachment: Fix, v3

Last one, for real. Apparently finish() returns.

Comment 3

[Brad Lassey [:blassey] (use needinfo?)]

Comment on attachment 496673 [details] [diff] [review]
Fix

It this patch doesn't do what the summary says. If you un-select the send report option and click close, we still show the progress dialog. Is that intentional?

Comment 4

[Michael Wu [:mwu]]

(In reply to comment #3)
> Comment on attachment 496673 [details] [diff] [review]
> Fix
> 
> It this patch doesn't do what the summary says. If you un-select the send
> report option and click close, we still show the progress dialog. Is that
> intentional?

That's what v3 fixes.

Comment 5

[Michael Wu [:mwu]]

http://hg.mozilla.org/mozilla-central/rev/e7e21099545f