Closed Bug 618217 Opened 9 years ago Closed 9 years ago

js::Anchor specialization for jsval could be cleaner

Categories

(Core :: JavaScript Engine, defect)

x86_64
Linux
defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: jimb, Unassigned)

References

Details

(Whiteboard: [fixed-in-tracemonkey])

Attachments

(1 file)

The way we take care of specializing js::Anchor for jsval in the non-__GNUC__ case seems more involved than it should be. Attached is a patch that specializes only the destructor. I think it makes the commonalities more obvious, and avoids the extraneous base class for AnchorPermitted.
Attachment #496731 - Flags: review?(bzbarsky)
Attachment #496731 - Flags: review?(bzbarsky) → review+
Try server likes it.
http://hg.mozilla.org/tracemonkey/rev/5014a17f1b25
Whiteboard: [fixed-in-tracemonkey]
http://hg.mozilla.org/mozilla-central/rev/5014a17f1b25
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.