Closed
Bug 618217
Opened 14 years ago
Closed 14 years ago
js::Anchor specialization for jsval could be cleaner
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: jimb, Unassigned)
References
Details
(Whiteboard: [fixed-in-tracemonkey])
Attachments
(1 file)
|
8.21 KB,
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
The way we take care of specializing js::Anchor for jsval in the non-__GNUC__ case seems more involved than it should be. Attached is a patch that specializes only the destructor. I think it makes the commonalities more obvious, and avoids the extraneous base class for AnchorPermitted.
Attachment #496731 -
Flags: review?(bzbarsky)
|
||
Updated•14 years ago
|
Attachment #496731 -
Flags: review?(bzbarsky) → review+
|
Reporter | |
Comment 1•14 years ago
|
||
Try server likes it.
|
|
Reporter | |
Comment 2•14 years ago
|
||
Whiteboard: [fixed-in-tracemonkey]
|
||
Comment 3•14 years ago
|
||
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•