Closed Bug 618262 Opened 14 years ago Closed 14 years ago

Removal of JS_NewString

Categories

(Core :: JavaScript Engine, defect)

Product:
Core
Component:
JavaScript Engine
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: igor, Assigned: igor)

References

Details

(Keywords: dev-doc-complete, Whiteboard: fixed-in-tracemonkey)

Attachments

(1 file)

v1
2.60 KB, patch
brendan
: review+
Details | Diff | Splinter Review 
From bug #617215 comment #2:

With the deflated cache removed JS_NewString no longer make sense as it
releases the passed char buffer after decoding it into a jschar array.
Attached patch v1 — — Splinter Review 
The patch just removes JS_NewString declaration and definition as the usage of the function was eliminated in the bug 617215.
Attachment #496788 - Flags: review?(brendan)
blocking2.0: beta8+ → ---
Comment on attachment 496788 [details] [diff] [review]
v1

*sniff*

I remember when 8 bits was enough. Heck, I remember 6-bit character sets (good on DEC's 36-bit CPUs, which had a variant of "8.3" that limited external symbols to 6 characters; octal made sense on those CPUs, too).

/be
Attachment #496788 - Flags: review?(brendan) → review+
http://hg.mozilla.org/tracemonkey/rev/a546d76bea6b
Whiteboard: fixed-in-tracemonkey
igor: have you fixed MDC? I wasn't allowed to add a single function without changing MDC and you're potentially breaking ever spidermonkey consumer in the world.
(In reply to comment #4)
> igor: have you fixed MDC?

I will do it.
Keywords: dev-doc-needed
http://hg.mozilla.org/mozilla-central/rev/a546d76bea6b
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: