Closed Bug 618268 Opened 9 years ago Closed 9 years ago

Tidy up the star panel a little

Categories

(SeaMonkey :: Bookmarks & History, defect)

x86
Windows XP
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: neil, Assigned: neil)

References

Details

Attachments

(3 files)

The star panel contains an unused element. Also the remove bookmark button looks a little out of place at the top of the panel, so I've tried moving it.
Attached patch Proposed patchSplinter Review
I also noticed that the "Edit This Bookmark" label was lonely; this seems to be because the icon has no theme, so I added some.
Assignee: nobody → neil
Status: NEW → ASSIGNED
Attachment #496790 - Flags: review?(iann_bugzilla)
Attached image Edit in classic
Attached image Edit in modern
Comment on attachment 496790 [details] [diff] [review]
Proposed patch

r=me with the gap at the top of the window fixed. Compare classic with modern - see attached screenshots. Modern's gap is just about acceptable (though ideally could do with an extra pixel or two) but classic it is too small. Though my eyes may be playing tricks on me.
Attachment #496790 - Flags: review?(iann_bugzilla) → review+
(In reply to comment #4)
> r=me with the gap at the top of the window fixed. Compare classic with modern -
> see attached screenshots. Modern's gap is just about acceptable (though ideally
> could do with an extra pixel or two) but classic it is too small. Though my
> eyes may be playing tricks on me.
Particularly as you're using Linux, where arrow panels don't work yet :-(
Hmm, looking at the screen shots, having "remove" and "cancel" right next to each other sounds dangerous for clicking the wrong thing. Could we have a spring between those two and have "remove" aligned at the start ("right") of the panel instead?
(In reply to comment #5)
> Particularly as you're using Linux, where arrow panels don't work yet :-(
Nor do they work in Modern :-(

(In reply to comment #6)
> Hmm, looking at the screen shots, having "remove" and "cancel" right next to
> each other sounds dangerous for clicking the wrong thing. Could we have a
> spring between those two and have "remove" aligned at the start ("right") of
> the panel instead?
Sure, I'll drop a spring in, but start == left, no?
(In reply to comment #7)
> Sure, I'll drop a spring in, but start == left, no?

Gah, sure, yes, I meant "left". Good that I said "start" as well. ;-)
Pushed changeset c671983f52d8 to comm-central.
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.