618268 - Tidy up the star panel a little

Status: RESOLVED FIXED

(SeaMonkey :: Bookmarks & History, defect)

Description

[[e-mail]]

The star panel contains an unused element. Also the remove bookmark button looks a little out of place at the top of the panel, so I've tried moving it.

Comment 1

[[e-mail]]

Attachment: Proposed patch

I also noticed that the "Edit This Bookmark" label was lonely; this seems to be because the icon has no theme, so I added some.

Comment 2

[Ian Neal]

Attachment: Edit in classic

Comment 3

[Ian Neal]

Attachment: Edit in modern

Comment 4

[Ian Neal]

Comment on attachment 496790 [details] [diff] [review]
Proposed patch

r=me with the gap at the top of the window fixed. Compare classic with modern - see attached screenshots. Modern's gap is just about acceptable (though ideally could do with an extra pixel or two) but classic it is too small. Though my eyes may be playing tricks on me.

Comment 5

[[e-mail]]

(In reply to comment #4)
> r=me with the gap at the top of the window fixed. Compare classic with modern -
> see attached screenshots. Modern's gap is just about acceptable (though ideally
> could do with an extra pixel or two) but classic it is too small. Though my
> eyes may be playing tricks on me.
Particularly as you're using Linux, where arrow panels don't work yet :-(

Comment 6

[Robert Kaiser]

Hmm, looking at the screen shots, having "remove" and "cancel" right next to each other sounds dangerous for clicking the wrong thing. Could we have a spring between those two and have "remove" aligned at the start ("right") of the panel instead?

Comment 7

[[e-mail]]

(In reply to comment #5)
> Particularly as you're using Linux, where arrow panels don't work yet :-(
Nor do they work in Modern :-(

(In reply to comment #6)
> Hmm, looking at the screen shots, having "remove" and "cancel" right next to
> each other sounds dangerous for clicking the wrong thing. Could we have a
> spring between those two and have "remove" aligned at the start ("right") of
> the panel instead?
Sure, I'll drop a spring in, but start == left, no?

Comment 8

[Robert Kaiser]

(In reply to comment #7)
> Sure, I'll drop a spring in, but start == left, no?

Gah, sure, yes, I meant "left". Good that I said "start" as well. ;-)

Comment 9

[[e-mail]]

Pushed changeset c671983f52d8 to comm-central.