Content processes don't report uptime correctly

RESOLVED FIXED

Status

()

RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: jdm, Assigned: jdm)

Tracking

unspecified
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(fennec-)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Updated

8 years ago
tracking-fennec: --- → ?
(Assignee)

Comment 1

8 years ago
Created attachment 496973 [details] [diff] [review]
Add StartupTime annotation to content crash reports.


Untested, based off of the code in PluginModuleParent.
jdm, should someone review or offer feedback on this?
(Assignee)

Comment 3

8 years ago
Not worth it until I actually see if it works correctly.
(Assignee)

Comment 4

8 years ago
Comment on attachment 496973 [details] [diff] [review]
Add StartupTime annotation to content crash reports.

And in fact it needs to be rebased and won't work as written.
Attachment #496973 - Attachment is obsolete: true
(Assignee)

Comment 5

8 years ago
Created attachment 497197 [details] [diff] [review]
Add StartupTime annotation to content crash reports.

More likely to work, but still untested.
jdm, love to accept, but not blocking fennec.  lets get it reviewed and tested.
tracking-fennec: ? → 2.0-
Assignee: nobody → josh
(Assignee)

Comment 7

8 years ago
Comment on attachment 497197 [details] [diff] [review]
Add StartupTime annotation to content crash reports.

Tested, content process crashes now have reasonable uptime fields.
Attachment #497197 - Flags: review?(ted.mielczarek)
Comment on attachment 497197 [details] [diff] [review]
Add StartupTime annotation to content crash reports.

This looks okay to me, but I think you really want cjones or some other IPC peer to review it, since it's not actually Breakpad code.
(Assignee)

Updated

8 years ago
Attachment #497197 - Flags: review?(ted.mielczarek) → review?(jones.chris.g)
Comment on attachment 497197 [details] [diff] [review]
Add StartupTime annotation to content crash reports.

Heh, "IPC peers".

This isn't the straw to break the refactorin' camel's back; fine with me.
Attachment #497197 - Flags: review?(jones.chris.g) → review+
Attachment #497197 - Flags: approval2.0+
http://hg.mozilla.org/mozilla-central/rev/8755d308796d
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.