Closed
Bug 618393
Opened 14 years ago
Closed 14 years ago
Content processes don't report uptime correctly
Categories
(Toolkit :: Crash Reporting, defect)
Tracking
()
RESOLVED
FIXED
Tracking | Status | |
---|---|---|
fennec | - | --- |
People
(Reporter: jdm, Assigned: jdm)
Details
Attachments
(1 file, 1 obsolete file)
2.51 KB,
patch
|
cjones
:
review+
dougt
:
approval2.0+
|
Details | Diff | Splinter Review |
Case in point: http://crash-stats.mozilla.com/report/index/89138fe8-4573-4a14-b7c9-2c7972101207
That is not a startup crash.
Assignee | ||
Updated•14 years ago
|
tracking-fennec: --- → ?
Assignee | ||
Comment 1•14 years ago
|
||
Untested, based off of the code in PluginModuleParent.
Comment 2•14 years ago
|
||
jdm, should someone review or offer feedback on this?
Assignee | ||
Comment 3•14 years ago
|
||
Not worth it until I actually see if it works correctly.
Assignee | ||
Comment 4•14 years ago
|
||
Comment on attachment 496973 [details] [diff] [review]
Add StartupTime annotation to content crash reports.
And in fact it needs to be rebased and won't work as written.
Attachment #496973 -
Attachment is obsolete: true
Assignee | ||
Comment 5•14 years ago
|
||
More likely to work, but still untested.
Comment 6•14 years ago
|
||
jdm, love to accept, but not blocking fennec. lets get it reviewed and tested.
tracking-fennec: ? → 2.0-
Updated•14 years ago
|
Assignee: nobody → josh
Assignee | ||
Comment 7•14 years ago
|
||
Comment on attachment 497197 [details] [diff] [review]
Add StartupTime annotation to content crash reports.
Tested, content process crashes now have reasonable uptime fields.
Attachment #497197 -
Flags: review?(ted.mielczarek)
Comment 8•14 years ago
|
||
Comment on attachment 497197 [details] [diff] [review]
Add StartupTime annotation to content crash reports.
This looks okay to me, but I think you really want cjones or some other IPC peer to review it, since it's not actually Breakpad code.
Assignee | ||
Updated•14 years ago
|
Attachment #497197 -
Flags: review?(ted.mielczarek) → review?(jones.chris.g)
Comment on attachment 497197 [details] [diff] [review]
Add StartupTime annotation to content crash reports.
Heh, "IPC peers".
This isn't the straw to break the refactorin' camel's back; fine with me.
Attachment #497197 -
Flags: review?(jones.chris.g) → review+
Updated•14 years ago
|
Attachment #497197 -
Flags: approval2.0+
Comment 10•14 years ago
|
||
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•