If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Provide a standalone builder to handle l10n repack respins

RESOLVED FIXED

Status

Release Engineering
General
RESOLVED FIXED
7 years ago
4 years ago

People

(Reporter: salbiz, Assigned: salbiz)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [l10n])

Attachments

(2 attachments, 3 obsolete attachments)

(Assignee)

Description

7 years ago
Created attachment 496889 [details] [diff] [review]
tools side standalone-repacks

Re-spinning specific individual locales during a release is a bit painful with the new chunked builders. The standalone builder should alleviate this. The patch doesn't use schedulers at all, so the builder is kicked off through force build, with required properties (locale, release_config, script_repo_revision) set through the force build form.
Attachment #496889 - Flags: review?(bhearsum)
(Assignee)

Comment 1

7 years ago
Created attachment 496890 [details] [diff] [review]
use scriptFactory to add standalone_repacks builder
Attachment #496890 - Flags: review?(bhearsum)

Comment 2

7 years ago
Good catch!
Whiteboard: [l10n]
Comment on attachment 496889 [details] [diff] [review]
tools side standalone-repacks

Per real life conversation, we need to support multiple locales in a single run of this. Likely solution is to be comma separated list of locales, which will need to be unpacked by this wrapper. Also shouldn't need the signed stuff.
Attachment #496889 - Flags: review?(bhearsum) → review-
Comment on attachment 496890 [details] [diff] [review]
use scriptFactory to add standalone_repacks builder

Needs adjusting for the signed stuff.
Attachment #496890 - Flags: review?(bhearsum)
(Assignee)

Comment 5

7 years ago
Created attachment 497975 [details] [diff] [review]
tools side standalone-repacks (multiple-locale support)

Adjusted to remove signing option and add support for multiple locales at a time
Attachment #496889 - Attachment is obsolete: true
Attachment #497975 - Flags: review?(bhearsum)
(Assignee)

Comment 6

7 years ago
Created attachment 497976 [details] [diff] [review]
use scriptFactory to add standalone_repacks builder (adjust to remove signing option)

Removed signing option
Attachment #496890 - Attachment is obsolete: true
Attachment #497976 - Flags: review?(bhearsum)
Comment on attachment 497975 [details] [diff] [review]
tools side standalone-repacks (multiple-locale support)

Almost; use 'unset IFS' to reset it rather than assigning a space. The default value is actually more complex (space, newline, tab -- I think).
Attachment #497975 - Flags: review?(bhearsum) → review-
Attachment #497976 - Flags: review?(bhearsum) → review+
(Assignee)

Comment 8

7 years ago
Created attachment 498737 [details] [diff] [review]
unset IFS properly

Done. Tests out locally.
Attachment #497975 - Attachment is obsolete: true
Attachment #498737 - Flags: review?(bhearsum)
Attachment #498737 - Flags: review?(bhearsum) → review+
Comment on attachment 497976 [details] [diff] [review]
use scriptFactory to add standalone_repacks builder (adjust to remove signing option)

Landed on default: changeset:   1319:ab8175be13cb


Syed, can you add docs to the Mercurial Release Automation page for this feature?
Attachment #497976 - Flags: checked-in+
Comment on attachment 498737 [details] [diff] [review]
unset IFS properly

Landed on default: changeset:   1906:8fa9dacec785
Attachment #498737 - Flags: checked-in+
Landed cleanly on Friday.
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.