Closed Bug 618434 Opened 9 years ago Closed 9 years ago

When device has no wireless connection (wifi or cell) jpake screen has no code

Categories

(Firefox for Android Graveyard :: General, defect)

x86
macOS
defect
Not set

Tracking

(fennec2.0+)

VERIFIED FIXED
Tracking Status
fennec 2.0+ ---

People

(Reporter: madhava, Assigned: wesj)

Details

(Keywords: polish, uiwanted)

Attachments

(4 files, 1 obsolete file)

Well, the bug is really that we show a page with a blank jpake section.  We should check to see if there's any network connection before we let you get to this screen.
blocking2.0: --- → ?
blocking2.0: ? → ---
tracking-fennec: --- → ?
It might just be about having a network connection -- but handling network errors (no route to host).  For example, when I connect to a open wifi network I have a internet connection, but I am restricted to only one IP until I sign in (e.g. MozillaGuest).

i think there might be two parts to this problem:

1) handle network failure more gracefully with some feedback to the user.

2) show some progress indicator (a wheel?) from the time the screen displays until the time we have the code.
tracking-fennec: ? → 2.0+
Attached image WIP screenshots
I have something in progress that looks like this. A loading indication while we get codes, and a simple error message if we detect a problem.

I also added some options to show when there is a failure (Retry and Manual Setup). Retry reloads the jpake page. Manual Setup is the same as clicking on the "I'm not near my computer" button. I hate having duplicated UI there, but wanted some feedback before I ran any further cleaning things up or writing better strings.
Attachment #497818 - Flags: feedback?(madhava)
Assignee: nobody → wjohnston
Keywords: polish, uiwanted
Here's what we do in Firefox Home around the same issues.

Before we go to the screen with the jpake code in it, we check to see if there's a network connection.  If there is not, we show this:
http://www.flickr.com/photos/madhava_work/5385839238/in/photostream/

(so a user is never looking at a blank jpake code page - now that we're using a android-style dialog instead of the black screen, we could throw up a smaller one for this message)

If there is a network connection, so the user gets to the jpake screen, but there's _then_ a problem, we show the following:
http://www.flickr.com/photos/madhava_work/5385840104/in/photostream/

Where "Manual Setup" goes to the enter your codes screen.
Attached patch Patch v1 (obsolete) — Splinter Review
Implements the same dialogs as Firefox Home. For two network error conditions we show the "No network" dialog. For all others we show a dialog with "Try Again", "Manual Setup", and "Cancel". Screenshots in a sec.
Attachment #507746 - Flags: ui-review?(madhava)
Attachment #507746 - Flags: review?(mark.finkle)
Attached image No network
Attached image Retry
Flags: in-litmus?(tchung)
Comment on attachment 507746 [details] [diff] [review]
Patch v1


>-    this.jpake.receiveNoPIN();
>+    //this.jpake.receiveNoPIN();
>+    setTimeout((function() {
>+      this.jpake.observer.onAbort("poo")
>+    }).bind(this), 1000);

Say what?

>+sync.setup.error.title=Cannot Setup Sync
>+sync.setup.error.network=No internet connection available
>+sync.setup.error.nodata=%S could not connect to Sync. Would you like to try again?
>+sync.setup.tryagain=Try again
>+sync.setup.manual=Manual Setup

"Manual setup"

r- until the "poo" is explained
Attachment #507746 - Flags: review?(mark.finkle) → review-
Whoops.

Made a few changes here. Now checks for network connectivity before showing the dialog at all. Services.io.offline does not seem to work, but the nsINetworkLinkService does (using airplane mode to test).

Also updated the "Try again" code slightly.
Attachment #507746 - Attachment is obsolete: true
Attachment #508011 - Flags: ui-review?(madhava)
Attachment #508011 - Flags: review?(mark.finkle)
Attachment #507746 - Flags: ui-review?(madhava)
Comment on attachment 508011 [details] [diff] [review]
Patch v2 - Poo-less

>+    // XXX: Services.io.offline is lying to us, so we use the NetworkLinkService instead

Drop the "XXX:", leave the comment
Attachment #508011 - Flags: review?(mark.finkle) → review+
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
VERIFIED FIXED on: 

Build ID: Mozilla /5.0 (Android;Linux armv7l;rv:2.2a1pre) Gecko/20110406 Firefox/4.2a1pre Fennec /4.1a1pre 

Device: Motorola Droid 2 (Android 2.2)
Status: RESOLVED → VERIFIED
Attachment #508011 - Flags: ui-review?(madhava)
Attachment #497818 - Flags: feedback?(madhava)
You need to log in before you can comment on or make changes to this bug.