618439 - VMPI TLS functions should be inlined

Status: RESOLVED FIXED

(Tamarin Graveyard :: Virtual Machine, defect)

Description

[Simon Wilkinson]

Attachment: Initial patch

This patch REALLY_INLINEs VMPI_tlsGetValue and VMPI_tlsSetValue.
Upcoming threading work will call these on the critical path.

Comment 1

[Felix S. Klock II [:pnkfelix, :fklock]]

Comment on attachment 496928 [details] [diff] [review]
Initial patch

During your own debugging, how valuable was that GCAssert that has gone away?  Was it valuable enough that we might consider making the DEBUG version of VMPI_tlsSetValue out of line so that it can keep the assertion?

Comment 2

[Simon Wilkinson]

(In reply to comment #1)
> Comment on attachment 496928 [details] [diff] [review]
> Initial patch
> 
> During your own debugging, how valuable was that GCAssert that has gone away? 
> Was it valuable enough that we might consider making the DEBUG version of
> VMPI_tlsSetValue out of line so that it can keep the assertion?

I never had it fire.
An out-of-line debug version is fine if you really want to keep it. Note that it's only the POSIX build that had the original assert. I don't see why that should be the case, hence why I removed it rather than putting it in the Windows build too.

Comment 3

[Tamarin Bot]

changeset: 5705:6b9a815d5b7e
user:      Simon Wilkinson <[e-mail]>
summary:   Bug 618439 - "VMPI TLS functions should be inlined" (r=fklockii,sr=edwsmith)

http://hg.mozilla.org/tamarin-redux/rev/6b9a815d5b7e