618525 - _create_locale needs to be paired with _free_locale

Status: RESOLVED FIXED

(Core :: Graphics: CanvasWebGL, defect)

Description

[Benoit Jacob [:bjacob] (mostly away)]

From bug 616290 comment 2:

Comment on attachment 494836 [details] [diff] [review]
upgrade to 498

>+#ifdef _MSC_VER
>+    return _atof_l(str, _create_locale(LC_NUMERIC, "C"));
Whoops. Every _create_locale needs to be paired with _free_locale...

Comment 1

[Benoit Jacob [:bjacob] (mostly away)]

Attachment: fix ANGLE locale leak

This fixes it.

Note that this is a leak with DOS implications since it's triggered by content. You could have a shader with 1000 float literals, and you could compile it repeatedly. So it should be a blocker.

Comment 2

[Benoit Jacob [:bjacob] (mostly away)]

Upstreamed: http://code.google.com/p/angleproject/issues/detail?id=93

Comment 3

[Benoit Jacob [:bjacob] (mostly away)]

http://hg.mozilla.org/mozilla-central/rev/32ebdd4db3b6

(vlad said a+ on IRC, and you should trust me anyway because I have implanted a trojan chip in your brain)