618542 - FF Home: Storage bump error should not proceed with log in

Status: VERIFIED FIXED

(Cloud Services Graveyard :: Firefox Home, defect)

Description

[Tony Chung [:tchung]]

Attachment: Storage incompatible screenshot

This seems to only happen in iOS4, as iOS3.1.3 seems to handle the error correctly.  Basically, if i'm on FF Home 1.1, and tried to sign in my account on an outdated storage build, the unsupported format error appears with an OK.  however, hitting OK, will still sign me into FF Home, where i can navigate through the menu.   This doesnt seem right, cause no collectionss are sync'd, so the app is useless.   

In IOS3, it seems to behave properly in that hitting OK just errs and takes you back to the sign in screen.

* See Screenshot

Repro:
1) install FF HOme 1.1b6
2) Try to sign in with a storage v3 or v4 account that was setup with Firefox3.6+1.5.1
3) Sign in is successful (through fallback), but an error dialog pops up.  Click OK
4) Verify the dialog is dismissed and you're free to navigate around the empty app

Expected:
- fail the sign on and take user back to the sign on screen

Actual:
- logged in with no sync'd collections.

Comment 1

[Tony Chung [:tchung]]

forgot to mention, i was testing my iphone 4, iOS 4.1.

Comment 2

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Fixed. Change set http://hg.mozilla.org/services/fx-home/rev/adce04988c78

Comment 3

[Tony Chung [:tchung]]

Verified fix on 1.1b6 12/13 build