Closed Bug 618606 Opened 13 years ago Closed 13 years ago

IndexedDB: keyPath parameter for createObjectStore should be optional

Categories

(Core :: Storage: IndexedDB, defect)

Product:
Core
Component:
Storage: IndexedDB
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
blocking2.0 --- -

People

(Reporter: bent.mozilla, Assigned: bent.mozilla)

Details

Attachments

(1 file, 1 obsolete file)

Patch, v1
4.43 KB, patch
sicking
: review+
Details | Diff | Splinter Review
Attached patch Patch, v1 (obsolete) — — Splinter Review 
Trivial spec compliance fix.
Attachment #497085 - Flags: review?(jonas)
Attachment #497085 - Attachment is patch: true
Attachment #497085 - Attachment mime type: application/octet-stream → text/plain
Attached patch Patch, v1 — — Splinter Review 
And bump iid.
Attachment #497085 - Attachment is obsolete: true
Attachment #497086 - Flags: review?(jonas)
Attachment #497085 - Flags: review?(jonas)
Comment on attachment 497086 [details] [diff] [review]
Patch, v1

Same thing here. Changing the optional-ness doesn't change the binary interface, so no need to change the iid. (But also doesn't hurt here probably).

Btw, why are we using AString here, and presumably elsewhere. Generally DOMString is probably better. That's a separate bug though.
Attachment #497086 - Flags: review?(jonas) → review+
This is one of the remaining bugs to finalize our IndexedDB story for Firefox 4. Blocking.
blocking2.0: ? → betaN+
http://hg.mozilla.org/mozilla-central/rev/9190301dbd61
Status: ASSIGNED → RESOLVED
blocking2.0: betaN+ → ?
Closed: 13 years ago
Resolution: --- → FIXED
blocking2.0: ? → -
Component: DOM → DOM: IndexedDB
Version: Trunk → unspecified
You need to log in before you can comment on or make changes to this bug.