Closed
Bug 618652
Opened 14 years ago
Closed 14 years ago
//@line n "f" busted, easy fix and test
Categories
(Core :: JavaScript Engine, defect, P3)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla2.0
People
(Reporter: brendan, Assigned: brendan)
Details
(Whiteboard: fixed-in-tracemonkey)
Attachments
(1 file)
|
1.98 KB,
patch
|
n.nethercote
:
review+
|
Details | Diff | Splinter Review |
I just noticed this. Patch once I have a bug #.
/be
|
Assignee | |
Updated•14 years ago
|
Assignee: general → brendan
Status: NEW → ASSIGNED
Priority: -- → P3
Target Milestone: --- → mozilla2.0
|
|
Assignee | |
Comment 1•14 years ago
|
||
Can c ever be other than EOF, specifically '\n', after the closing filename " has been got?
/be
Attachment #497121 -
Flags: review?(nnethercote)
|
||
Comment 2•14 years ago
|
||
I can't reproduce the error -- I get no assertion failure with that test case.
|
|
Assignee | |
Comment 3•14 years ago
|
||
(In reply to comment #2)
> I can't reproduce the error -- I get no assertion failure with that test case.
Aha -- the bug bites only if you interact with the shell using stdin from a pty. I'm on Mac, using default editline.
Nick, I'd like to have the test coverage for the eval case. I don't have a good idea for how to test the interactive case but the patch does fix it. You ok to review the jsscan.cpp change?
/be
|
|
||
Updated•14 years ago
|
Attachment #497121 -
Flags: review?(nnethercote) → review+
|
|
Assignee | |
Comment 4•14 years ago
|
||
Whiteboard: fixed-in-tracemonkey
|
||
Comment 5•14 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•