618662 - nsIDocument::GetWindow() should be a const method

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Mihai Sucan [:msucan]]

The nsIDocument::GetWindow() method should be constant.

(followup from bug 606498 ... see comments #47, #51 and #54)

Comment 1

[David Humphrey (:humph)]

Anna's going to give this a shot.  Assigning by request.

Comment 2

[Anna [:annasob]]

Attachment: Patch fro bug 618662

Comment 3

[Anna [:annasob]]

I wasn't sure if I should make OuterWindowID() constant as per comment 47 of bug 606498

Comment 4

[Boris Zbarsky [:bzbarsky]]

> I wasn't sure if I should make OuterWindowID() constant

Please do!

Comment 5

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 508018 [details] [diff] [review]
Patch fro bug 618662

> +  virtual nsPIDOMWindow *GetWindowInternal()  const = 0;

There's an extra space there before "const".   Other than that, looks good.

Comment 6

[Anna [:annasob]]

Attachment: Patch for bug 618662

I created a new patch. This one fixes the extra space and also makes OuterWindowID() constant

Comment 7

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 508880 [details] [diff] [review]
Patch for bug 618662

Looks great; thanks!

Comment 8

[Boris Zbarsky [:bzbarsky]]

Should land this once the tree reopens; adding dependency so we don't lose it.

Comment 9

[(no longer active)]

http://hg.mozilla.org/mozilla-central/rev/32b7f464e29f

Comment 10

[Boris Zbarsky [:bzbarsky]]

Anna, thank you again for the patch.