618694 - xulrunner help dialog text has trailing garbage

Status: RESOLVED FIXED

(Toolkit Graveyard :: XULRunner, defect)

Description

[Sean Bright]

User-Agent:       Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b8pre) Gecko/20101209 Firefox/4.0b8pre
Build Identifier: 1.9.2.14pre

The Output() function in nsXULRunnerApp.cpp assumes that the output will be less than 1024 characters.  With long version numbers (i.e. 1.9.2.14pre) this is not the case the the trailing \0 gets blow away resulting in invalid output.

Reproducible: Always

Steps to Reproduce:
1. Run xulrunner.exe without an arguments

Comment 1

[Sean Bright]

Attachment: Screenshot of the characters

Screenshot showing the corruption

Comment 2

[Sean Bright]

Attachment: Patch

Increase the buffer size to 2k instead of 1k.

Comment 3

[Matthias Versen [:Matti]]

bsmedberg: Sorry to disturb you but how do we get this patch get into the tree ?
The tree is currently approval only, should I request that or should I wait until the tree opens for FF5 ?
I don't want to forget this patch  and I don't think Sean knows how to get this into the tree.

Comment 4

[Sean Bright]

(In reply to comment #3)
> I don't want to forget this patch  and I don't think Sean knows how to get this
> into the tree.

You are correct, although I'd be happy to take a stab at it.  Can you point me to a document that describes the process?

Comment 5

[Benjamin Smedberg]

Comment on attachment 497146 [details] [diff] [review]
Patch

I can approve this, it's basically risk-free. I'll add the keyword to get it checked in as a ridealong, although I'm not sure who is doing pushes at this point.

Comment 6

[Sean Bright]

Sorry - why was this assigned to me?  I don't have commit access.

Comment 7

[(not currently active) Ted Mielczarek]

Because you wrote the patch, that's how we manage things in Bugzilla. The "checkin-needed" flag is an annotation we use for this very situation, so hopefully someone will land your patch for you.

Comment 8

[Phil Ringnalda (:philor)]

http://hg.mozilla.org/mozilla-central/rev/a79259022980