Closed Bug 618716 Opened 10 years ago Closed 10 years ago

warning: comparison between signed and unsigned integer expressions in nsPermissionManager.cpp

Categories

(Core :: Networking: Cookies, defect)

Product:
Core
Component:
Networking: Cookies
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla2.0b12

People

(Reporter: jdm, Assigned: jdm)

Details

(Whiteboard: [build_warning])

Attachments

(1 file)

Fix warnings in nsPermissionManager.cpp
2.53 KB, patch
dwitte
: review+
jst
: approval2.0+
Details | Diff | Splinter Review 
/Users/moco/src/mobilebase/extensions/cookie/nsPermissionManager.cpp: In member function    sresult nsPermissionManager::Init()
/Users/moco/src/mobilebase/extensions/cookie/nsPermissionManager.cpp:234: warning: comparison between signed and unsigned integer expressions

unrelatedly, but also fixable is:

/Users/moco/src/mobilebase/extensions/cookie/nsPermissionManager.cpp: In member function    sresult nsPermissionManager::AddInternal(const nsAFlatCString&, const nsAFlatCString&, PRUint32, PRInt64,
/Users/moco/src/mobilebase/extensions/cookie/nsPermissionManager.cpp:484: warning: ignoring return value of    ool mozilla::dom::PContentParent::SendAddPermission(const IPC::Permission&)    decla      $
Assignee: nobody → josh
Attachment #497169 - Flags: review?(dwitte)
Comment on attachment 497169 [details] [diff] [review]
Fix warnings in nsPermissionManager.cpp

Nice. r=dwitte
Attachment #497169 - Flags: review?(dwitte) → review+
Comment on attachment 497169 [details] [diff] [review]
Fix warnings in nsPermissionManager.cpp

Warning reduction is always nice.
Attachment #497169 - Flags: approval2.0?
Attachment #497169 - Flags: approval2.0? → approval2.0+
Keywords: checkin-needed
http://hg.mozilla.org/mozilla-central/rev/bc9d7938cdc7
Status: NEW → RESOLVED
Closed: 10 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b12
You need to log in before you can comment on or make changes to this bug.