618759 - Stop putting bloaturls.txt and bloatcycle.html in dist/bin/res/ where nothing wants them

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Phil Ringnalda (:philor)]

Attachment: rm

In the beginning was xpfe, and xpfe was with bad ideas, and xpfe was bad ideas.

The xpfe nsBrowserInstance had a commandline argument of sorts, where if you started it with -f then after the fact it would check that arg, if you had built debug/trace-malloc/with ENABLE_PAGE_CYCLER defined, would read the file you passed in that arg, and would cycle through the URLs in it.

BloatTest.pm used that to cycle through the URLs in bloaturls.txt.

Then along came TestGtkEmbed, which didn't implement -f, but wanted to run bloat tests, so BloatTest2.pm allowed it to instead load bloatcycle.html, then along came Firefox, which wanted nothing to do with -f, so BloatTest2.pm also allowed it to load bloatcycle.html.

Then along came SeaMonkey's lack of desire to maintain the crap which toolkit had forked, so now there is nothing which supports -f, and nothing which wants to see bloaturls.txt, and along came buildbot replacing Tinderbox, using build/leaktest.py.in instead of BloatTest2.pm, so there's nothing which knows how to call the binaries that don't support -f with a -f arg that they don't support.

Comment 1

[Phil Ringnalda (:philor)]

Comment on attachment 497202 [details] [diff] [review]
rm

Bah, all that archeology, and I still didn't notice that we actually separately stick bloatcycle.html in objdir/_leaktest, so all the installing of it in dist/bin/res and not packaging it has been pointless since we switched to buildbot.

Comment 2

[Phil Ringnalda (:philor)]

Attachment: moar rm

Though fortunately, we'd already cleaned up all the not-packaging of it and taken care of removing it anywhere that we'd accidentally shipped it, so all we need to do is stop sticking it in dist/bin/res/ where we don't want it to be.

Comment 3

[(not currently active) Ted Mielczarek]

Comment on attachment 497224 [details] [diff] [review]
moar rm

I think you've finally made yourself into the official Mozilla historian.

Comment 4

[Phil Ringnalda (:philor)]

http://hg.mozilla.org/mozilla-central/rev/af7da6fedc6e

Comment 5

[Serge Gautherie (:sgautherie)]

Good. Shouldn't the remaining references be removed too?

Comment 6

[Phil Ringnalda (:philor)]

No.

Comment 7

[(not currently active) Ted Mielczarek]

Although anyone can have r+a=me to hg rm testing/tinderbox-standalone-tests.

Comment 8

[Phil Ringnalda (:philor)]

Since mxr doesn't index whatever repo those lived in before, so that they were my only way to discover who used bloaturls.txt and how, and my only way to discover the lack of fidelity in porting what they did to buildbot in things like bug 603539, anyone who does will also be pushing with enmity=philor.

Comment 9

[(not currently active) Ted Mielczarek]

http://mxr.mozilla.org/mozilla/source/testing/tinderbox-standalone-tests/ ?

It's not as though things don't live on forever in our VCS history.