Closed Bug 618759 Opened 9 years ago Closed 9 years ago

Stop putting bloaturls.txt and bloatcycle.html in dist/bin/res/ where nothing wants them

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla2.0b8

People

(Reporter: philor, Assigned: philor)

References

()

Details

Attachments

(1 file, 1 obsolete file)

Attached patch rm (obsolete) — Splinter Review
In the beginning was xpfe, and xpfe was with bad ideas, and xpfe was bad ideas.

The xpfe nsBrowserInstance had a commandline argument of sorts, where if you started it with -f then after the fact it would check that arg, if you had built debug/trace-malloc/with ENABLE_PAGE_CYCLER defined, would read the file you passed in that arg, and would cycle through the URLs in it.

BloatTest.pm used that to cycle through the URLs in bloaturls.txt.

Then along came TestGtkEmbed, which didn't implement -f, but wanted to run bloat tests, so BloatTest2.pm allowed it to instead load bloatcycle.html, then along came Firefox, which wanted nothing to do with -f, so BloatTest2.pm also allowed it to load bloatcycle.html.

Then along came SeaMonkey's lack of desire to maintain the crap which toolkit had forked, so now there is nothing which supports -f, and nothing which wants to see bloaturls.txt, and along came buildbot replacing Tinderbox, using build/leaktest.py.in instead of BloatTest2.pm, so there's nothing which knows how to call the binaries that don't support -f with a -f arg that they don't support.
Attachment #497202 - Flags: review?(ted.mielczarek)
Assignee: nobody → philringnalda
Comment on attachment 497202 [details] [diff] [review]
rm

Bah, all that archeology, and I still didn't notice that we actually separately stick bloatcycle.html in objdir/_leaktest, so all the installing of it in dist/bin/res and not packaging it has been pointless since we switched to buildbot.
Attachment #497202 - Attachment is obsolete: true
Attachment #497202 - Flags: review?(ted.mielczarek)
Attached patch moar rmSplinter Review
Though fortunately, we'd already cleaned up all the not-packaging of it and taken care of removing it anywhere that we'd accidentally shipped it, so all we need to do is stop sticking it in dist/bin/res/ where we don't want it to be.
Attachment #497224 - Flags: review?(ted.mielczarek)
Summary: Remove suite's bloaturls.txt → Stop putting bloaturls.txt and bloatcycle.html in dist/bin/res/ where nothing wants them
Comment on attachment 497224 [details] [diff] [review]
moar rm

I think you've finally made yourself into the official Mozilla historian.
Attachment #497224 - Flags: review?(ted.mielczarek)
Attachment #497224 - Flags: review+
Attachment #497224 - Flags: approval2.0+
http://hg.mozilla.org/mozilla-central/rev/af7da6fedc6e
Flags: in-testsuite-
Target Milestone: --- → mozilla2.0b8
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Good. Shouldn't the remaining references be removed too?
No.
Although anyone can have r+a=me to hg rm testing/tinderbox-standalone-tests.
Since mxr doesn't index whatever repo those lived in before, so that they were my only way to discover who used bloaturls.txt and how, and my only way to discover the lack of fidelity in porting what they did to buildbot in things like bug 603539, anyone who does will also be pushing with enmity=philor.
http://mxr.mozilla.org/mozilla/source/testing/tinderbox-standalone-tests/ ?

It's not as though things don't live on forever in our VCS history.
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.