618778 - Unwrapping a chrome window created by content has wrapped properties

Status: RESOLVED INACTIVE

(Core :: XPConnect, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: testcase (patch)

Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0b8pre) Gecko/20101204 Firefox/4.0b8pre ID:20101204030328

In one of our shared modules for Mozmill which is handling modal dialogs, I can see that after unwrapping a chrome window, which has been opened by content, some window properties are still wrapped.

Steps:
1. Install Mozmill (https://developer.mozilla.org/en/Mozmill#Installation)
2. Get our Mozmill tests from http://hg.mozilla.org/qa/mozmill-tests/
3. Patch the repository with the testcase attached to this bug
4. Run Mozmill with (-t firefox/testSecurity/testEncryptedPageWarning.js)

Check the dump messages in the console:

*** window before: [object ChromeWindow]
*** window after: [object ChromeWindow]
*** opener before: [object XrayWrapper [object Window]]

Comment 1

[Andreas Gal :gal]

Attachment: patch

Comment 2

[Johnny Stenback (:jst)]

Attachment: XUL document fix.

This patch makes the XUL document code only use the XUL prototype cache when the XUL document is loaded in a type=chrome docshell. This is needed with Andreas' patch to avoid compartment mismatches when loading XUL scripts since chrome XUL documents can now end up being loaded in more than one compartment.

And Andreas, with this patch your testcase loads w/o compartment mismatches, but the test still fails.

Comment 3

[Andreas Gal :gal]

jst, I was thinking the other thing we can try is putting extensions into their own compartment. That might be lower-impact. I will try to figure out why the test case still fails.

Comment 4

[Andreas Gal :gal]

This is a softblocker. We are very seriously considering not blocking on this. The fixes seem all higher risk that the small amount of breakages this introduces.

Comment 5

[Andreas Gal :gal]

Henrik, can you explain how this affects you? Can you easily work around this?

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+2]]

It happens when I call getMostRecentWindow from inside our Mozmill scripts. For now I simply have to unwrap the window a second time, so I'm completely fine for now. So no need from my side for a hardblocker.

Comment 7

[Andreas Gal :gal]

I think we should unblock on this until we have some evidence that this really creates a headache for extension developers. jst, please overrule me if you disagree.

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+2]]

jst, can we get an update on this bug please?

Comment 9

[BMO Automation]

Per policy at https://wiki.mozilla.org/Bug_Triage/Projects/Bug_Handling/Bug_Husbandry#Inactive_Bugs. If this bug is not an enhancement request or a bug not present in a supported release of Firefox, then it may be reopened.