Closed Bug 618800 Opened 10 years ago Closed 9 years ago

MOZ_XMLIsNCNameChar and MOZ_XMLIsLetter should have /* fall through */ comments for switches

Categories

(Core :: XML, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla5

People

(Reporter: timeless, Assigned: timeless)

References

(Blocks 1 open bug, )

Details

(Keywords: coverity)

Attachments

(1 file)

130 int MOZ_XMLIsNCNameChar(const char* ptr)
131 {
132   switch (BYTE_TYPE(ptr)) {
133   case BT_NONASCII:
134     if (!IS_NAME_CHAR_MINBPC(ptr)) {
135       return 0;
136     }

please add /* fall through */ here (or just return 1;)

137   case BT_NMSTRT:
138   case BT_HEX:
139   case BT_DIGIT:
140   case BT_NAME:
141   case BT_MINUS:
142     return 1;
143   default:
144     return 0;
145   }
146 }
Summary: MOZ_XMLIsNCNameChar should have a /* fall through */ comment for switch → MOZ_XMLIsNCNameChar and MOZ_XMLIsLetter should have /* fall through */ comments for switches
Attached patch add commentsSplinter Review
Assignee: nobody → timeless
Status: NEW → ASSIGNED
Attachment #497317 - Flags: review?(jonas)
Attachment #497317 - Flags: approval2.0?
Comment on attachment 497317 [details] [diff] [review]
add comments

Mass minusing patch approval that don't have high return. Please renominate if this is more important for 2.0 than it appears.
Attachment #497317 - Flags: approval2.0? → approval2.0-
http://hg.mozilla.org/mozilla-central/rev/13370fb7a65a
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.2
You need to log in before you can comment on or make changes to this bug.