618807 - Two items are highlighted in bookmarks menu

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Hideo Oshima]

Attachment: Screen shot for Bookmarks menu

Steps to reproduce:
1. Open Bookmarks menu
2. Point Bookmarks menu item
3. Move mouse down to open sub menu(bookmark folder)
4. Move mouse left to point sub menu
5. Move mouse down and right to point bookmarks menu

Yesterday's build doesn't have this problem.

Comment 1

[Alice0775 White]

This highlight problem happens on not only bookmarks menu but also  context menu
[STR]
1. Start Minefield with new profile
2. Select text in Location bar
3. Right click in the location and Choose "Copy"
4. Right click in the location bar again
[Actual Result]
Previous chosen item "Copy" was highlighted
[Expected Result]
No item is highlighted

Regression window:
Works:
http://hg.mozilla.org/mozilla-central/rev/25d77f95d92c
Mozilla/5.0 (X11; Linux i686; rv:2.0b8pre) Gecko/20101212 Firefox/4.0b8pre ID:20101212030333
Fails:
http://hg.mozilla.org/mozilla-central/rev/bdfc000c60fe
Mozilla/5.0 (X11; Linux i686; rv:2.0b8pre) Gecko/20101212 Firefox/4.0b8pre ID:20101212074642
Pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=25d77f95d92c&tochange=bdfc000c60fe

I guess this is regressed by 34bd12eb4a9c	Oleg Romashin — Bug 615870 - Remote HTML5 video rendering pipeline should be shorter r=roc a=b-f

Comment 2

[Will Roberts [:bws42]]

I haven't checked the regression range, but I'm seeing a similar highlight issue where if you type into the awesome bar then use the arrow keys to navigate through the results, the currently focused result isn't highlighted. I'll check tonight and file a separate bug if it's not the same range.

Comment 3

[Alice0775 White]

(In reply to comment #2)
> I haven't checked the regression range, but I'm seeing a similar highlight
> issue where if you type into the awesome bar then use the arrow keys to
> navigate through the results, the currently focused result isn't highlighted.
> I'll check tonight and file a separate bug if it's not the same range.

I can confirm and I got a same regression range

Comment 4

[Oleg Romashin (:romaxa)]

Attachment: Mark tree for update even if damageRect is empy

Problem is that damageRect is empty and tree stay without updates...

Comment 5

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 497280 [details] [diff] [review]
Mark tree for update even if damageRect is empy

The patch is OK but can you explain what the bug is and why this fixes it?

Comment 6

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Anyone can land this.

Comment 7

[Phil Ringnalda (:philor)]

Not any more they can't, since bug 615870 was backed out.

Comment 8

[Robert O'Callahan (:roc) (email my personal email if necessary)]

That works too!

Comment 9

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Fixed by backout.