618822 - for loop for NSS_ENABLE_ECC could be a while() loop in SSL_CanBypass

Status: RESOLVED INVALID

(NSS :: Libraries, enhancement, P5)

Description

[timeless]

587 SSL_CanBypass(CERTCertificate *cert, SECKEYPrivateKey *srvPrivkey,

730 #ifdef NSS_ENABLE_ECC
731         for (; (privKeytype == ecKey && ( testecdh || testecdhe)) ||
732                (privKeytype == rsaKey && testecdhe); ) {

741             if (privKeytype == ecKey && testecdhe) {
744             } else if (privKeytype == rsaKey && testecdhe) {

753                 if (requiredECCbits < 0)
754                     break;

773                 if (rv == SECFailure) {
774                     break;
775                 }
777             }
778 
779             if (testecdhe) {
782                 if (!keapriv || !keapub) {
789                     break;
790                 }
796             }
797 
801             if (!cpriv || !cpub) {
808                 break;
809             }
827             if (rv == SECSuccess && *pcanbypass == PR_FALSE)
828                 goto done;
829             break;

this line is not reachable:
830         }
831 #endif /* NSS_ENABLE_ECC */