Closed Bug 618830 Opened 9 years ago Closed 9 years ago

initial assignment to kidNextInFlow is useless in nsTableFrame::ReflowChildren

Categories

(Core :: Layout: Tables, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla5

People

(Reporter: timeless, Assigned: timeless)

References

(Blocks 1 open bug, )

Details

(Keywords: coverity)

Attachments

(1 file)

2670 nsTableFrame::ReflowChildren(nsTableReflowState& aReflowState,
2674 {

2780       // record the presence of a next in flow, it might get destroyed so we
2781       // need to reorder the row group array
2782       nsIFrame* kidNextInFlow = kidFrame->GetNextInFlow();

either the preceding line should be dropped and the decl moved, or the following line should use 'kidNextInFlow':
2784       if (kidFrame->GetNextInFlow())
2785         reorder = PR_TRUE;

2853       // Special handling for incomplete children
2854       if (NS_FRAME_IS_NOT_COMPLETE(aStatus)) {
2855         kidNextInFlow = kidFrame->GetNextInFlow();
2856         if (!kidNextInFlow) {

2859           rv = presContext->PresShell()->FrameConstructor()->
2860             CreateContinuingFrame(presContext, kidFrame, this, &kidNextInFlow);

2867           mFrames.InsertFrame(nsnull, kidFrame, kidNextInFlow);

2876         rowGroups.InsertElementAt(childX + 1,
2877                            static_cast <nsTableRowGroupFrame*>(kidNextInFlow));

2889       }
2890     }
Assignee: nobody → timeless
Status: NEW → ASSIGNED
Attachment #497322 - Flags: review?(bzbarsky)
Attachment #497322 - Flags: review?(bzbarsky) → review+
Attachment #497322 - Flags: approval2.0?
Comment on attachment 497322 [details] [diff] [review]
proposal a - remove declaration

Please land this after we branch for Gecko 2.0 / Firefox 4.
Attachment #497322 - Flags: approval2.0? → approval2.0-
http://hg.mozilla.org/mozilla-central/rev/3fe96cdaa5d6
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.2
You need to log in before you can comment on or make changes to this bug.