Closed Bug 618889 Opened 9 years ago Closed 9 years ago

Web Console doesn't animate away when you click the close button

Categories

(DevTools :: General, defect, P3)

defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: pcwalton, Assigned: pcwalton)

References

Details

(Keywords: polish)

Attachments

(1 file, 1 obsolete file)

Title says it all. Pressing Cmd+Shift+K makes the console animation trigger, as does choosing the menu item, but clicking the close button doesn't.
Attached patch Proposed patch. (obsolete) — Splinter Review
Proposed patch attached.
Attachment #497385 - Flags: feedback?(mihai.sucan)
Patch version 2 actually fixes the problem.
Assignee: nobody → pwalton
Attachment #497385 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #497387 - Flags: feedback?(mihai.sucan)
Attachment #497385 - Flags: feedback?(mihai.sucan)
Blocks: devtools4
Priority: -- → P3
Comment on attachment 497387 [details] [diff] [review]
[checked-in] Proposed patch, version 2.

The fix is fine, but I am not sure if we should or not have a mochitest for this bug. Aren't we supposed to test for UI bugs as well? If you believe no test is needed, go ahead and ask for review.
Attachment #497387 - Flags: feedback?(mihai.sucan) → feedback+
Comment on attachment 497387 [details] [diff] [review]
[checked-in] Proposed patch, version 2.

Yeah, I thought of that, but I couldn't think of an easy way to test this, since the animation is done in CSS.
Attachment #497387 - Flags: review?(sdwilsh)
Comment on attachment 497387 [details] [diff] [review]
[checked-in] Proposed patch, version 2.

r=sdwilsh
Attachment #497387 - Flags: review?(sdwilsh) → review+
Attachment #497387 - Flags: approval2.0?
Attachment #497387 - Flags: approval2.0? → approval2.0+
Keywords: checkin-needed
Comment on attachment 497387 [details] [diff] [review]
[checked-in] Proposed patch, version 2.

http://hg.mozilla.org/mozilla-central/rev/43b33e90152f
Attachment #497387 - Attachment description: Proposed patch, version 2. → [checked-in] Proposed patch, version 2.
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
(In reply to comment #4)
> Comment on attachment 497387 [details] [diff] [review]
> [checked-in] Proposed patch, version 2.
> 
> Yeah, I thought of that, but I couldn't think of an easy way to test this,
> since the animation is done in CSS.

You could intercept the animate function and ensure it is called when the x button is clicked.
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.