Closed Bug 618996 Opened 9 years ago Closed 9 years ago

nsDisplayClipRoundedRect::TryMerge always returns PR_FALSE

Categories

(Core :: Web Painting, defect, minor)

defect
Not set
minor

Tracking

()

RESOLVED FIXED

People

(Reporter: mats, Assigned: mats)

Details

Attachments

(1 file)

Attached patch Like so?Splinter Review
nsDisplayClipRoundedRect::TryMerge always returns PR_FALSE

I assume you want to compare the contents of the mRadii arrays
rather than pointers.
http://mxr.mozilla.org/mozilla-central/source/layout/base/nsDisplayList.cpp#1656

(it doesn't fix bug 613905 though)

Do I need an explicit
#include <string.h>
or can I depend on basic xpcom header files always doing that?
(currently it's pulled in by nsCharTraits.h for example)
Attachment #497422 - Flags: review?(dbaron)
Comment on attachment 497422 [details] [diff] [review]
Like so?

r=dbaron
Attachment #497422 - Flags: review?(dbaron) → review+
Comment on attachment 497422 [details] [diff] [review]
Like so?

If this helps merge some rounded rect clips it could help our perf issues with rounded rect clips.
Attachment #497422 - Flags: approval2.0?
Attachment #497422 - Flags: approval2.0? → approval2.0+
Feel free to land it.  (I'm stranded in London due to the snow and I probably won't be back home until Wednesday)
Assignee: nobody → matspal
http://hg.mozilla.org/mozilla-central/rev/fec77e3eca12

(Hope you get home soon (or are already there).)
Status: NEW → RESOLVED
Closed: 9 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Whiteboard: [needs landing]
Component: Layout: View Rendering → Layout: Web Painting
You need to log in before you can comment on or make changes to this bug.