Closed
Bug 618996
Opened 15 years ago
Closed 15 years ago
nsDisplayClipRoundedRect::TryMerge always returns PR_FALSE
Categories
(Core :: Web Painting, defect)
Core
Web Painting
Tracking
()
RESOLVED
FIXED
People
(Reporter: MatsPalmgren_bugz, Assigned: MatsPalmgren_bugz)
Details
Attachments
(1 file)
|
909 bytes,
patch
|
dbaron
:
review+
dbaron
:
approval2.0+
|
Details | Diff | Splinter Review |
nsDisplayClipRoundedRect::TryMerge always returns PR_FALSE
I assume you want to compare the contents of the mRadii arrays
rather than pointers.
http://mxr.mozilla.org/mozilla-central/source/layout/base/nsDisplayList.cpp#1656
(it doesn't fix bug 613905 though)
Do I need an explicit
#include <string.h>
or can I depend on basic xpcom header files always doing that?
(currently it's pulled in by nsCharTraits.h for example)
Attachment #497422 -
Flags: review?(dbaron)
Comment on attachment 497422 [details] [diff] [review]
Like so?
r=dbaron
Attachment #497422 -
Flags: review?(dbaron) → review+
|
||
Comment 2•15 years ago
|
||
Comment on attachment 497422 [details] [diff] [review]
Like so?
If this helps merge some rounded rect clips it could help our perf issues with rounded rect clips.
Attachment #497422 -
Flags: approval2.0?
Attachment #497422 -
Flags: approval2.0? → approval2.0+
|
Assignee | |
Comment 3•15 years ago
|
||
Feel free to land it. (I'm stranded in London due to the snow and I probably won't be back home until Wednesday)
Keywords: checkin-needed
Whiteboard: [needs landing]
|
||
Updated•15 years ago
|
Assignee: nobody → matspal
|
|
||
Comment 4•15 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/fec77e3eca12
(Hope you get home soon (or are already there).)
Status: NEW → RESOLVED
Closed: 15 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Whiteboard: [needs landing]
|
||
Updated•7 years ago
|
Component: Layout: View Rendering → Layout: Web Painting
You need to log in
before you can comment on or make changes to this bug.
Description
•