Closed
Bug 618998
Opened 13 years ago
Closed 13 years ago
Star UI is checking for about:blank before the real visited page
Categories
(Toolkit :: Places, defect)
Tracking
()
RESOLVED
FIXED
mozilla2.0b9
People
(Reporter: mak, Assigned: mak)
Details
(Keywords: perf, Whiteboard: [fixed-in-places])
Attachments
(1 file)
1.15 KB,
patch
|
sdwilsh
:
review+
sdwilsh
:
approval2.0+
|
Details | Diff | Splinter Review |
Running Txul, I see the star trying to figure out if about:blank is bookmarked before checking for the real page. Actually I don't think there is any interesting effect on bookmarking or checking about:blank, we should just bail out on it and don't even show the star.
Assignee | ||
Updated•13 years ago
|
Assignee: nobody → mak77
Status: NEW → ASSIGNED
Assignee | ||
Comment 1•13 years ago
|
||
This removes some useless reads.
Attachment #497537 -
Flags: review?(sdwilsh)
Comment 2•13 years ago
|
||
Comment on attachment 497537 [details] [diff] [review] patch v1.0 r=sdwilsh
Attachment #497537 -
Flags: review?(sdwilsh)
Attachment #497537 -
Flags: review+
Attachment #497537 -
Flags: approval2.0+
Assignee | ||
Comment 3•13 years ago
|
||
http://hg.mozilla.org/projects/places/rev/23c8f19e51f1
Whiteboard: [fixed-in-places]
Assignee | ||
Comment 4•13 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/23c8f19e51f1
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b9
You need to log in
before you can comment on or make changes to this bug.
Description
•