Closed Bug 618998 Opened 9 years ago Closed 9 years ago

Star UI is checking for about:blank before the real visited page

Categories

(Toolkit :: Places, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla2.0b9

People

(Reporter: mak, Assigned: mak)

Details

(Keywords: perf, Whiteboard: [fixed-in-places])

Attachments

(1 file)

Running Txul, I see the star trying to figure out if about:blank is bookmarked before checking for the real page. Actually I don't think there is any interesting effect on bookmarking or checking about:blank, we should just bail out on it and don't even show the star.
Assignee: nobody → mak77
Status: NEW → ASSIGNED
Attached patch patch v1.0Splinter Review
This removes some useless reads.
Attachment #497537 - Flags: review?(sdwilsh)
Comment on attachment 497537 [details] [diff] [review]
patch v1.0

r=sdwilsh
Attachment #497537 - Flags: review?(sdwilsh)
Attachment #497537 - Flags: review+
Attachment #497537 - Flags: approval2.0+
http://hg.mozilla.org/mozilla-central/rev/23c8f19e51f1
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b9
You need to log in before you can comment on or make changes to this bug.