Closed Bug 619023 Opened 14 years ago Closed 9 years ago

stop building nsGB2312ToUnicodeV2 and nsUnicodeToISO2022CN

Categories

(Core :: Internationalization, enhancement)

Product:
Core
Component:
Internationalization
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED WORKSFORME

People

(Reporter: timeless, Unassigned)

References

Details

Attachments

(1 file, 1 obsolete file)

and replace contracts
25.43 KB, patch
Details | Diff | Splinter Review
/usr/bin/ranlib: file: libucvcn_s.a(nsGB2312ToUnicodeV2.o) has no symbols /usr/bin/ranlib: file: libucvcn_s.a(nsUnicodeToISO2022CN.o) has no symbols /usr/bin/ranlib: file: libucvcn_s.a(nsCP936ToUnicode.o) has no symbols /usr/bin/ranlib: file: libucvcn_s.a(nsUnicodeToCP936.o) has no symbols ranlib: file: libucvcn_s.a(nsGB2312ToUnicodeV2.o) has no symbols ranlib: file: libucvcn_s.a(nsUnicodeToISO2022CN.o) has no symbols ranlib: file: libucvcn_s.a(nsCP936ToUnicode.o) has no symbols ranlib: file: libucvcn_s.a(nsUnicodeToCP936.o) has no symbols
Attached patch remove files/includes (obsolete) — — Splinter Review
Assignee: smontagu → timeless
Status: NEW → ASSIGNED
Attachment #497462 - Flags: review?(smontagu)
Attachment #497462 - Flags: approval2.0?
Comment on attachment 497462 [details] [diff] [review] remove files/includes The CP936 and GB2312 converters are used, so you can't just remove them, though you may be able to remove the empty .cpp files. The ISO-2022-CN changes look good.
Attachment #497462 - Flags: review?(smontagu)
Attachment #497462 - Flags: review-
Attachment #497462 - Flags: approval2.0?
Attachment #497462 - Attachment is obsolete: true
Attachment #498168 - Flags: review?(smontagu)
Attachment #498168 - Flags: approval2.0?
Attachment #498168 - Flags: approval2.0?
Windows-936 stuff will be removed by bug 651113.
OS: Mac OS X → All
Hardware: x86 → All
Summary: stop building nsGB2312ToUnicodeV2, nsUnicodeToISO2022CN, nsCP936ToUnicode, and nsUnicodeToCP936 → stop building nsGB2312ToUnicodeV2 and nsUnicodeToISO2022CN
Ms2ger, are you interested in taking this?
Comment on attachment 498168 [details] [diff] [review] and replace contracts Review of attachment 498168 [details] [diff] [review]: ----------------------------------------------------------------- remove request for bitrotted patch.
Attachment #498168 - Flags: review?(smontagu)
Assignee: timeless → nobody
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Depends on: 651113, 928231
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: