619031 - scam warnings in a plaintext message

Status: RESOLVED FIXED

(SeaMonkey :: MailNews: Message Display, defect)

Description

[Lapo Luchini]

User-Agent:       Mozilla/5.0 (X11; U; FreeBSD amd64; en-US) AppleWebKit/534.14 (KHTML, like Gecko) Chrome/10.0.603.0 Safari/534.14
Build Identifier: Mozilla/5.0 (X11; U; FreeBSD amd64; en-US; rv:1.9.1.15) Gecko/20101102 SeaMonkey/2.0.10

I have received a scam warning in a plaintext email, probably on the basis that a link wasn't what I seemed to be, which seems a bit silly to me since a plaintext can't hide anything and the link was auto-generated.

Reproducible: Always

Steps to Reproduce:
This is what I think what happened:
1. the email contained the almost-link "url=http://127.0.0.1:<port>/service?wsdl"
2. the "http://127.0.0.1:" part became an auto-generated link to "http://127.0.0.1/"
3. the link was found linking to an URL different from what it did show and this activated the scam warning
Actual Results:  
Scam warning.

Expected Results:  
Auto-generated links should not be subject to the "different text from link" warning since, well, they are auto-generated and moreover a plaintext message can't possibly have "hidden" links or stuff.

I can't attach the full email as it is work related and kinda private, but shouldn't bee to difficult to reproduce the problem including the URL I mentioned in the body of any mail.

Comment 1

[Bruno 'Aqualon' Escherl]

Confirming with Mozilla/5.0 (X11; U; Linux i686 (x86_64); en-US; rv:1.9.1.17pre) Gecko/20101209 Lightning/1.0b1 SeaMonkey/2.0.12pre

May be a backend issue, don't know how scam detection works.

Funny thing, the bug mail also shows the scam warning ;)

Comment 2

[Karsten Düsterloh]

I think this means that we basically want to port bug 362434 from TB, which - among other things - fixes this.

Comment 3

[Tony Mechelynck [:tonymec]]

Bug 362434 is all in one JS file, but no one-liner (-58, +166). I wonder how easy the port will be…

…Hm, for one thing, trying to "dumbly" apply the patch to the suite file of the same name (suite/mailnews/phishingDetector.js) results in all three hunks being rejected. Will need some more love.

Comment 4

[Wasim Thabraze]

Hello,

Is this bug still open? I love to work on this bug.

Can one of the mentors assign this bug to me? I hope to get it resolved.

Thank you.

Comment 5

[Tony Mechelynck [:tonymec]]

(In reply to Wasim Thabraze from comment #4)
> Hello,
> 
> Is this bug still open? I love to work on this bug.
> 
> Can one of the mentors assign this bug to me? I hope to get it resolved.
> 
> Thank you.

Earlier comments mention Thunderbird bug 362434, but I think that this particular bug might be the SeaMonkey equivalent of Thunderbird bug 937265. You might want to have a look at both of them.

I'm not specifically a mentor, but I've fixed a few very simple bugs, and I love it when I see someone new willing to work on SeaMonkey bugs. I hope you won't find this bug too hard for you. ;-)

Comment 6

[Tony Mechelynck [:tonymec]]

Wasim: Any progress (or questions)?

Comment 7

[Wasim Thabraze]

Sorry for the inactivity @Tony. My health wasn't supporting me.

By the way, I'm starting to work on this bug. I'll update the progress soon!

Thank You.

Comment 8

[athosar1452]

I'd like to get started on this bug if its up for grabs?

Comment 9

[Kohei Yoshino]

I don’t know anything about this bug.

Comment 10

[athosar1452]

(In reply to Kohei Yoshino [:kohei] from comment #9)

I don’t know anything about this bug.

Sorry, just saw that you updated it and thought you did

Comment 11

[Frank-Rainer Grahl (:frg)]

Yes still available. Have you built SeaMonkey recently?

Comment 12

[Favour]

Hi, I am new to contributing to Mozilla.
I would like someone to guide me through fixing this bug.

Comment 13

[omega judith]

HEY IS this still available?

Comment 14

[Frank-Rainer Grahl (:frg)]

Attachment: 619031-cc-25317.patch

[Approval Request Comment]
Regression caused by (bug #): --
User impact if declined: Wrong spam warning
Testing completed (on m-c, etc.): 2.53.17b1 pre
Risk to taking this patch (and alternatives if risky): pretty easy to test
String changes made by this patch: --

To test compose an email and add a link like http://130.0.0.1:49419. Send as plain text and you should see the spam warning in the current release.

Comment 15

[Ian Neal]

Comment on attachment 9332056 [details] [diff] [review]
619031-cc-25317.patch

[Triage Comment]
LGTM r/a=me

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/57304dec23e8
Disable spam warning for autogenerated links in plaintext messages. r=IanN

Comment 17

[Frank-Rainer Grahl (:frg)]

https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/b242593368e8004f1802f527ef241c4a8c5ef9eb
Disable spam warning for autogenerated links in plaintext messages. r=IanN a=IanN