619057 - Tab modal prompts hide the whole website in Winstripe

Status: RESOLVED FIXED

(Firefox :: Theme, defect)

Description

[JK]

User-Agent:       Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b7) Gecko/20100101 Firefox/4.0b7
Build Identifier: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b8pre) Gecko/20101214 Firefox/4.0b8pre

Tab modal prompts hide the whole website.

Reproducible: Always

Steps to Reproduce:
Type javascript:alert("hello") to the address bar and press enter.
Actual Results:  
The whole webpage is hidden.

Expected Results:  
Should be dimmed slightly.

Comment 1

[JK]

Attachment: pic

Comment 2

[Maniac Vlad Florin (:vladmaniac)]

I am pretty sure this is intended. Invalid?

Comment 3

[JK]

(In reply to comment #2)
> I am pretty sure this is intended. Invalid?

It's supposed to be something like this:

https://bug613714.bugzilla.mozilla.org/attachment.cgi?id=492193

Comment 4

[Michael Lefevre]

(In reply to comment #2)
> I am pretty sure this is intended. Invalid?

I don't think so. Bug 613714 was originally supposed to be for switching from the blur to dimming. It was decided to land the removal of the slow effects for beta 8, and work on the styling later. There doesn't seem to be another bug for that yet, so I guess this one will do.

Comment 5

[Maniac Vlad Florin (:vladmaniac)]

Great! I also confirm this as an issue, then.

Comment 6

[Unknown W. Brackets]

Can't there just be an opacity rule added to the css?  Are SVG effects really
necessary to make the dim non-opaque?

I read from the original bug that the *desaturation* was being removed, not the
*opacity*, necessarily.  At least that's what I gathered from bug 613714
comment 54 - 57.

If it stays like this for final, along with the imho questionable design
decision of making the alerts look as if they are "from the webpage" (but
obviously look nothing like other elements on the page, the browser, or etc.
and are completely unchangeable), I anticipate a lot of confused and annoyed
comments from many of the people I've converted to Firefox.  Alas.

-[Unknown]

Comment 7

[Kemcy BEST]

Confirmed @
https://bugzilla.mozilla.org/show_bug.cgi?id=613714#c64
and voted.

Comment 8

[Mike Beltzner [:beltzner, not reading bugmail]]

Ugh. It hurts me to block on this. We could in theory ship b8 without it, but it would be a visible problem and it's a one line CSS fix.

Comment 9

[Mike Beltzner [:beltzner, not reading bugmail]]

(Do that again, jmjeffery, and I'll change your bz privs so that you can't. Midair collision warnings mean something, and please take the time to observe them)

Comment 10

[JK]

(In reply to comment #9)
> (Do that again, jmjeffery, and I'll change your bz privs so that you can't.
> Midair collision warnings mean something, and please take the time to observe
> them)

Unfortunately, there are no midair collision warnings if the refresh button is used. It is a Bugzilla or Firefox bug. It's better to use the "Bug 619057" link in the title of the bug, so that the fields, like "blocking", are updated properly. The refresh button does not update the fields.

Comment 11

[:Gavin Sharp [email: [e-mail]]]

https://hg.mozilla.org/mozilla-central/rev/a272338eb57a