Note: There are a few cases of duplicates in user autocompletion which are being worked on.

Command line options --new-tab and --new-window not documented

VERIFIED FIXED in Firefox 5

Status

()

Firefox
General
VERIFIED FIXED
7 years ago
6 years ago

People

(Reporter: Matěj Cepl, Assigned: pascalc)

Tracking

unspecified
Firefox 5
All
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Reporter)

Description

7 years ago
Neither --help message or firefox's man page contains any mention
about (quite handy) command line options for opening the page in
a new tab or window. I think it would be nice if we get at least
these two (as I believe there are some more) properly documented.

Version-Release number of selected component (if applicable):
firefox-3.6.12-1.fc14.x86_64
(Reporter)

Updated

7 years ago

Updated

7 years ago
Hardware: x86_64 → All
Whiteboard: [good first bug]
(Assignee)

Comment 1

7 years ago
Created attachment 502237 [details] [diff] [review]
patch adding the options for --help

Here is a patch adding those options to --help for trunk, not sure who I should ask a review though.
Assignee: nobody → pascalc
(Assignee)

Comment 2

7 years ago
Comment on attachment 502237 [details] [diff] [review]
patch adding the options for --help

bug 458631 shows that gavin was the last reviewer for this area of the code :)
Attachment #502237 - Flags: review?(gavin.sharp)

Comment 3

7 years ago
Comment on attachment 502237 [details] [diff] [review]
patch adding the options for --help

-new-tab and -new-window only applies to Firefox and Seamonkey:
https://developer.mozilla.org/en/Command_Line_Options#Browser

So adding them for all toolkit apps is wrong. You'll want to add that to e.g. nsBrowserContentHandler.js instead.
Hint: http://mxr.mozilla.org/mozilla-central/ident?i=helpInfo

Also add -search and -preferences while you're at it.
Attachment #502237 - Flags: review?(gavin.sharp) → review-
(Assignee)

Comment 4

7 years ago
oh ok, i'll provide a new patch soon, thanks Steffen
(Assignee)

Comment 5

7 years ago
Created attachment 503715 [details] [diff] [review]
updated patch

Here is an updated patch hopefully correct now :)
Attachment #502237 - Attachment is obsolete: true
Attachment #503715 - Flags: review?(steffen.wilberg)

Comment 6

7 years ago
I'm not a formal reviewer, but it looks technically ok to me.

Two little nits though:
1. Put -preferences before -search to not regress alphabetical ordering further.
2. I don't like "Options/Preferences window". It's a dialog, not a window, and it's Options on Windows and Preferences on Linux and Mac. You could duplicate that line and use #ifdef XP_WIN #else #endif to write the correct text for each platform.
(Assignee)

Comment 7

7 years ago
Created attachment 503845 [details] [diff] [review]
updated patch
(Assignee)

Comment 8

7 years ago
Comment on attachment 503845 [details] [diff] [review]
updated patch

Updated patch including Steffen recommandations.
Attachment #503845 - Attachment description: * → updated patch
Attachment #503845 - Flags: review?(gavin.sharp)
(Assignee)

Updated

7 years ago
Attachment #503715 - Attachment is obsolete: true
Attachment #503715 - Flags: review?(steffen.wilberg)
Comment on attachment 503845 [details] [diff] [review]
updated patch

This isn't exhaustive, but the other flags aren't really worth exposing so that's fine.
Attachment #503845 - Flags: review?(gavin.sharp) → review+
Component: Help Documentation → General
QA Contact: help.documentation → general
(Assignee)

Updated

6 years ago
Keywords: push-needed
(Assignee)

Comment 10

6 years ago
Is the push-needed keyword enough to get it landed or should I ask for a specific approval in the patch details page?

Comment 11

6 years ago
The correct keyword is checkin-needed (cvs terminology). push-needed is only used for website/webtool bugs (click on the "keywords" link to get a description).

And yes, it should be enough to get it landed.
Keywords: push-needed → checkin-needed
(Assignee)

Comment 12

6 years ago
Thanks Steffen (I am a webdev and usually work on websites, that's probably why I made this mistake being used to put push-needed in my bugs!)
http://hg.mozilla.org/projects/cedar/rev/d086123baa23
Keywords: checkin-needed
Whiteboard: [good first bug] → fixed-in-cedar
http://hg.mozilla.org/mozilla-central/rev/555486eb0c03
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Whiteboard: fixed-in-cedar
Target Milestone: --- → Firefox4.2
Verified on: 
Build identifier: Mozilla/5.0 (X11; Linux i686; rv:2.2a1pre) Gecko/20110405 Firefox/4.2a1pre
Status: RESOLVED → VERIFIED

Updated

6 years ago
Target Milestone: Firefox5 → Firefox 5
You need to log in before you can comment on or make changes to this bug.