Last Comment Bug 619069 - Command line options --new-tab and --new-window not documented
: Command line options --new-tab and --new-window not documented
Product: Firefox
Classification: Client Software
Component: General (show other bugs)
: unspecified
: All Linux
: -- normal (vote)
: Firefox 5
Assigned To: Pascal Chevrel:pascalc
Depends on:
  Show dependency treegraph
Reported: 2010-12-14 07:50 PST by Matěj Cepl
Modified: 2011-04-13 03:02 PDT (History)
7 users (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

patch adding the options for --help (1.17 KB, patch)
2011-01-08 07:21 PST, Pascal Chevrel:pascalc
steffen.wilberg: review-
Details | Diff | Splinter Review
updated patch (1.02 KB, patch)
2011-01-13 18:47 PST, Pascal Chevrel:pascalc
no flags Details | Diff | Splinter Review
updated patch (1.10 KB, patch)
2011-01-14 07:33 PST, Pascal Chevrel:pascalc review+
Details | Diff | Splinter Review

Description Matěj Cepl 2010-12-14 07:50:39 PST
Neither --help message or firefox's man page contains any mention
about (quite handy) command line options for opening the page in
a new tab or window. I think it would be nice if we get at least
these two (as I believe there are some more) properly documented.

Version-Release number of selected component (if applicable):
Comment 1 Pascal Chevrel:pascalc 2011-01-08 07:21:40 PST
Created attachment 502237 [details] [diff] [review]
patch adding the options for --help

Here is a patch adding those options to --help for trunk, not sure who I should ask a review though.
Comment 2 Pascal Chevrel:pascalc 2011-01-13 04:00:52 PST
Comment on attachment 502237 [details] [diff] [review]
patch adding the options for --help

bug 458631 shows that gavin was the last reviewer for this area of the code :)
Comment 3 Steffen Wilberg 2011-01-13 04:28:43 PST
Comment on attachment 502237 [details] [diff] [review]
patch adding the options for --help

-new-tab and -new-window only applies to Firefox and Seamonkey:

So adding them for all toolkit apps is wrong. You'll want to add that to e.g. nsBrowserContentHandler.js instead.

Also add -search and -preferences while you're at it.
Comment 4 Pascal Chevrel:pascalc 2011-01-13 04:32:16 PST
oh ok, i'll provide a new patch soon, thanks Steffen
Comment 5 Pascal Chevrel:pascalc 2011-01-13 18:47:20 PST
Created attachment 503715 [details] [diff] [review]
updated patch

Here is an updated patch hopefully correct now :)
Comment 6 Steffen Wilberg 2011-01-14 02:25:30 PST
I'm not a formal reviewer, but it looks technically ok to me.

Two little nits though:
1. Put -preferences before -search to not regress alphabetical ordering further.
2. I don't like "Options/Preferences window". It's a dialog, not a window, and it's Options on Windows and Preferences on Linux and Mac. You could duplicate that line and use #ifdef XP_WIN #else #endif to write the correct text for each platform.
Comment 7 Pascal Chevrel:pascalc 2011-01-14 07:33:41 PST
Created attachment 503845 [details] [diff] [review]
updated patch
Comment 8 Pascal Chevrel:pascalc 2011-01-14 07:34:49 PST
Comment on attachment 503845 [details] [diff] [review]
updated patch

Updated patch including Steffen recommandations.
Comment 9 :Gavin Sharp [email:] 2011-03-16 17:48:53 PDT
Comment on attachment 503845 [details] [diff] [review]
updated patch

This isn't exhaustive, but the other flags aren't really worth exposing so that's fine.
Comment 10 Pascal Chevrel:pascalc 2011-03-23 23:24:55 PDT
Is the push-needed keyword enough to get it landed or should I ask for a specific approval in the patch details page?
Comment 11 Steffen Wilberg 2011-03-23 23:40:18 PDT
The correct keyword is checkin-needed (cvs terminology). push-needed is only used for website/webtool bugs (click on the "keywords" link to get a description).

And yes, it should be enough to get it landed.
Comment 12 Pascal Chevrel:pascalc 2011-03-23 23:43:47 PDT
Thanks Steffen (I am a webdev and usually work on websites, that's probably why I made this mistake being used to put push-needed in my bugs!)
Comment 15 Simona B [:simonab ] 2011-04-05 08:15:34 PDT
Verified on: 
Build identifier: Mozilla/5.0 (X11; Linux i686; rv:2.2a1pre) Gecko/20110405 Firefox/4.2a1pre

Note You need to log in before you can comment on or make changes to this bug.