183.37 KB, patch
|Details | Diff | Splinter Review|
The configure.in script shows some instances of AC_ARG_WITH where AC_ARG_ENABLE should have been used. These macros work identically (apart from setting differently-named variables), but it is convention that WITH is used only for _external_ packages, e.g. AC_ARG_WITH(libpng, [--with-libpng[=DIR] Use system libpng], ...) and ENABLE is used to enable/disable internal features, e.g. AC_ARG_ENABLE(extensions, [--enable-extensions Compile in extensions], ...) Also, there is an unwritten convention that the help texts be written like this: --with-libpng[=DIR] Use system libpng i.e. write (literally) DIR instead of $dir and instead of NAME or anything else. This helps e.g. for zsh with autocompletion.
Marking NEW so someone with more experience can look at it and invalidate/validate it.
Setting milestones to Future.
As well as renaming certain options, I took this opportunity to reorganize configure.in. Options have been lumped into categories which makes the webconfig output (with headers) make more sense. Options & tests that have been commented out for quite a while have been removed as well as tests for features that we no longer support. The following options have been removed: --enable-monolithic-toolkit --disable-jar-packaging The following options have been renamed: --with-jpeg --with-system-jpeg --with-zlib --with-system-zlib --with-png --with-system-png --with-mng --with-system-mng --enable-toolkit --enable-default-toolkit --with-gtk --enable-toolkit-gtk --with-xlib --enable-toolkit-xlib --with-qt --enable-toolkit-qt --enable-gle --enable-gle-support --with-extensions --enable-extensions --enable-modules --enable-standalone-modules --enable-lea --enable-xpcom-lea --enable-ultrasparc --enable-js-ultrasparc --enable-strip-libs --enable-strip --with-debug-modules --enable-debug-modules --with-dbgrinfo-modules --enable-dbgrinfo-modules --with-profile-modules --enable-profile-modules --enable-eazel-profiler --enable-eazel-profiler-support --enable-chrome --enable-chrome-format --enable-homedir --with-user-appdir --enable-static-components --enable-meta-component-modules The old names will continue to work until the extra checks are removed next milestone.
Status: NEW → ASSIGNED
Priority: P3 → P1
Comment on attachment 54793 [details] [diff] [review] Long overdue renaming Argh. stupid dos-line endings.
Attachment #54793 - Attachment is obsolete: true
Created attachment 55195 [details] [diff] [review] Updated with newsgroup suggestions & fixed some MOZ_ARG usage
Attachment #54800 - Attachment is obsolete: true
um. chrome hackers very much expect to be able to use --disable-jar-packaging. not to mention the few people who build on systems where the jar packager isn't installed. please put it back.
As I've posted in the newsgroups a couple of times now, --disable-jar-packaging has been deprecated for a couple of milestones now. It's not coming back. Use --enable-chrome-format and start reading m.builds or at least look at the other configure options first. The jar packager? You mean zip? It's a hard requirement now as well.
Most of the fallout seems to be over. Marking fixed.
Status: ASSIGNED → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → FIXED
I think this caused bug 108044.
You need to log in before you can comment on or make changes to this bug.