619089 - onKeyDown event, do not add the character!

Status: VERIFIED FIXED

(Core :: DOM: UI Events & Focus Handling, defect)

Description

[[e-mail]]

User-Agent:       Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b7) Gecko/20100101 Firefox/4.0b7
Build Identifier: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b7) Gecko/20100101 Firefox/4.0b7

When i use onKeyDown event on firefox 4, the letter typed to not get displayed.
Like this:
<input type="TEXT" onkeydown="alert(this.value)" />
If i click the A letter on blank input field, it will display a blank alert (correct), but do not add the A letter clicked.
I'm usning firefox 4 beta 7!

Reproducible: Always

Steps to Reproduce:
1.create a html file
2.create a input field with keydown event with anything like an alert;
3.click any letter, or number
Actual Results:  
Do not work properly the typed letter

Expected Results:  
Display the typed word before

Comment 1

[(mostly gone) XtC4UaLL [:xtc4uall]]

Seeing this with Mozilla/5.0 (Windows NT 5.1; rv:2.0b8pre) Gecko/20101214 Firefox/4.0b8pre ID:20101214030322 too.

Works in Firefox 3.6.x.

Comment 2

[(mostly gone) XtC4UaLL [:xtc4uall]]

Attachment: Reporter's Testcase

Comment 3

[Boris Zbarsky [:bzbarsky]]

Presumably the issue is that we lose focus or something and then the keyup goes to a different place and there is no keypress on the text control?

Neil, what do other UAs do?

Comment 4

[Neil Deakin]

Works fine for me on Mac; the character just doesn't appear until after the alert is dismissed, which is the expected behaviour. Safari behaves the same.

Doesn't work on Windows though. Not sure why the difference.

Comment 5

[Boris Zbarsky [:bzbarsky]]

The attached testcase doesn't work for me on mac.  If I dismiss the alert with the mouse, typeaheadfind opens with the char I typed.  If I dismiss it with the keyboard, the original char is just lost....

Comment 6

[Johnny Stenback (:jst)]

Neil, can you have a look here?

Comment 7

[Neil Deakin]

This is because the focus is changing between content and chrome during a keypress. We fixed the cases where focus changed from chrome to content during a keypress in bug 551434, but not other cases as Olli believed it was too regression risky.

Comment 8

[Neil Deakin]

Attachment: patch

This would fix it but haven't tested it much.

Comment 9

[Neil Deakin]

Comment on attachment 506432 [details] [diff] [review]
patch

Olli, any thoughts on what issues this might cause?

Comment 10

[Neil Deakin]

Attachment: patch with test

Comment 11

[Neil Deakin]

http://hg.mozilla.org/mozilla-central/rev/059044e44314

Comment 12

[Steve Scott (pxbugz)]

Verified fixed in Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b12pre) Gecko/20110204 Firefox/4.0b12pre