nsMemoryReporterManager should be threadsafe

RESOLVED FIXED

Status

()

RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: dougt, Assigned: dougt)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

8 years ago
In bug 615978, I really wanted to report sqlite memory usage.  I was adding reporters on a non-main thread.  Doing it any other way is a harder.  Ideally, any thread could add, remove, and enumerate the reporters.

This patch basically locks the array and protects mRefCount.
(Assignee)

Comment 1

8 years ago
Created attachment 497523 [details] [diff] [review]
patch v.1
Attachment #497523 - Flags: review?(vladimir)
Comment on attachment 497523 [details] [diff] [review]
patch v.1

looks good!
Attachment #497523 - Flags: review?(vladimir) → review+
(Assignee)

Updated

8 years ago
Blocks: 615978
(Assignee)

Updated

8 years ago
Attachment #497523 - Flags: approval2.0?
Attachment #497523 - Flags: approval2.0? → approval2.0+
(Assignee)

Comment 3

8 years ago
http://hg.mozilla.org/mozilla-central/rev/398c0e73be64
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.