619160 - release_sanity.py should allow using a particular config file

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Rail Aliiev [:rail]]

For Firefox 4.0 beta releases we use release-firefox-mozilla-2.0.py config file and mozilla-central branch. The current code assumes that
releaseConfigFile = "release-firefox-%s.py" % options.branch

Comment 1

[Syed Albiz [:salbiz]]

Attachment: support specifying a specific releaseConfig from commandline options

Tested against my user repos. Do we want to do some additional verification to make sure that the branchname matches the sourceRepoName in the releaseConfig, or will that break us down the line?

Comment 2

[Rail Aliiev [:rail]]

Comment on attachment 497988 [details] [diff] [review]
support specifying a specific releaseConfig from commandline options

Looks OK.

Comment 3

[[e-mail] (:bhearsum)]

Comment on attachment 497988 [details] [diff] [review]
support specifying a specific releaseConfig from commandline options

Since we're passing both branch and a config file name now it would be sensible to verify that branch == releaseConfig['sourceRepoName']. Looks fine otherwise.

Comment 4

[Syed Albiz [:salbiz]]

Attachment: check that the branch matches sourceRepoName in the release config

Done.

Comment 5

[[e-mail] (:bhearsum)]

Comment on attachment 498733 [details] [diff] [review]
check that the branch matches sourceRepoName in the release config

Can you make releaseConfig a required option, and drop the staging flag altogether? Sorry I didn't mention this in the first pass.

Comment 6

[Syed Albiz [:salbiz]]

Attachment: remove --staging option and make -c/--release-config a required option

Done.

Comment 7

[[e-mail] (:bhearsum)]

Comment on attachment 498739 [details] [diff] [review]
remove --staging option and make -c/--release-config a required option

Landed on default: changeset:   1907:f38b7cffa756

Comment 8

[[e-mail] (:bhearsum)]

Syed, can you update the documentation page for this?

Comment 9

[[e-mail] (:bhearsum)]

Syed updated the docs last week.