Closed Bug 619160 Opened 15 years ago Closed 15 years ago

release_sanity.py should allow using a particular config file

Categories

(Release Engineering :: General, defect)

Product:
Release Engineering
Component:
General
Platform:
x86
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: rail, Assigned: salbiz)

Details

(Whiteboard: [releases])

Attachments

(1 file, 2 obsolete files)

remove --staging option and make -c/--release-config a required option
6.62 KB, patch
bhearsum
: review+
bhearsum
: checked-in+
Details | Diff | Splinter Review
For Firefox 4.0 beta releases we use release-firefox-mozilla-2.0.py config file and mozilla-central branch. The current code assumes that releaseConfigFile = "release-firefox-%s.py" % options.branch
Tested against my user repos. Do we want to do some additional verification to make sure that the branchname matches the sourceRepoName in the releaseConfig, or will that break us down the line?
Attachment #497988 - Flags: review?(rail)
Attachment #497988 - Flags: review?(bhearsum)
Comment on attachment 497988 [details] [diff] [review] support specifying a specific releaseConfig from commandline options Looks OK.
Attachment #497988 - Flags: review?(rail) → review+
Comment on attachment 497988 [details] [diff] [review] support specifying a specific releaseConfig from commandline options Since we're passing both branch and a config file name now it would be sensible to verify that branch == releaseConfig['sourceRepoName']. Looks fine otherwise.
Attachment #497988 - Flags: review?(bhearsum) → review-
Done.
Attachment #497988 - Attachment is obsolete: true
Attachment #498733 - Flags: review?(bhearsum)
Comment on attachment 498733 [details] [diff] [review] check that the branch matches sourceRepoName in the release config Can you make releaseConfig a required option, and drop the staging flag altogether? Sorry I didn't mention this in the first pass.
Attachment #498733 - Flags: review?(bhearsum) → review-
Done.
Attachment #498733 - Attachment is obsolete: true
Attachment #498739 - Flags: review?(bhearsum)
Attachment #498739 - Flags: review?(bhearsum) → review+
Comment on attachment 498739 [details] [diff] [review] remove --staging option and make -c/--release-config a required option Landed on default: changeset: 1907:f38b7cffa756
Attachment #498739 - Flags: checked-in+
Syed, can you update the documentation page for this?
Syed updated the docs last week.
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: