619164 - Assertion: JSID_IS_EMPTY(cursor->id) in test_service_detect_upgrade.js

Status: RESOLVED WORKSFORME

(Core :: JavaScript Engine, defect)

Description

[Josh Matthews [:jdm]]

Attachment: Backtrace

With the patch from bug 508128 applied, test_service_detect_upgrade.js fails a js assertion on every platform on try (and locally).  Backtrace attached.

Comment 1

[Josh Matthews [:jdm]]

Drilling down some more, this function fails:

>  getAllIDs: function BStore_getAllIDs() {
>    let items = {"menu": true,
>                 "toolbar": true};
>    for (let [guid, id] in Iterator(kSpecialIds))
>      if (guid != "places" && guid != "tags")
>        this._getChildren(guid, items);
>    return items;
>  },

Specifically the call to Iterator, as demonstrated in the backtrace.

Comment 2

[Nicholas Nethercote [inactive]]

Bug 508128 is not a blocker.  Does that mean this should also not be a blocker?

Comment 3

[Josh Matthews [:jdm]]

You are correct that 508128 isn't a blocker, but my thinking is that this might be exposing a legitimate problem in the JS engine which should at least be investigated.

Comment 4

[David Mandelin [:dmandelin]]

An assertion alone doesn't block at this point, unless indicates an critical security issue.

Comment 5

[Josh Matthews [:jdm]]

Yay, I no longer see this.