619166 - Make all string control character sanitization handle invalid characters as well

Status: NEW

(Camino Graveyard :: General, defect)

Description

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

I noticed last night that the fancy location-bar sanitizing code, BWC's |cleanPastedText:|, cleans not only control characters, but also invalid characters.

All of our uses of |stringByReplacingCharactersInSet:withString:| to sanitize (save the one in CHStringBundleOverride, which is doing something else entirely, and arguably is not sanitizing in the way we use sanitizing elsewhere) only clean control characters.

If we care enough to strip invalid characters in some places (BWC's callers of |cleanPastedText:|, which prior to bug 411165 just stripped control characters), it seems to me like we ought to care in all other places where we strip control characters.

I think we should consider uplifting the NSCharacterSet part (or at least the illegalAndControlCharacterSet-creation part of the NSCharacterSet part) of |cleanPastedText:| to some common place and then converting all other |stringByReplacingCharactersInSet:[NSCharacterSet controlCharacterSet]| callers to |stringByReplacingCharactersInSet:[NSCharacterSet illegalAndControlCharacterSet]|.

Comment 1

[Chris Lawson (gone)]

I and Wevah both agree we should do this.