Closed Bug 619182 Opened 13 years ago Closed 13 years ago

Convert moz_indexedDB to mozIndexedDB

Categories

(Core :: Storage: IndexedDB, defect)

Product:
Core
Component:
Storage: IndexedDB
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
blocking2.0 --- -

People

(Reporter: dougt, Assigned: dougt)

Details

(Keywords: dev-doc-complete)

Attachments

(2 files, 1 obsolete file)

patch v.1 (core)
1.20 KB, patch
sicking
: review+
sicking
: approval2.0+
Details | Diff | Splinter Review
patch v.2 (tests)
42.05 KB, patch
sicking
: review+
sicking
: approval2.0+
Details | Diff | Splinter Review 
most (all?) mozilla specific objects in content are prefixed by moz not moz_.  So,

moz_indexedDB really must be mozIndexedDB.
I agree, but Tantek seems to have other opinion about vendor prefixing
https://wiki.mozilla.org/Tantek-Mozilla-projects#DOM_API_vendor_prefixing
standardization of non-standard implementation object names is interesting, but I am not sure what sort of long term value there is.

I do value the consistency with all other non-standard object names we have used.
Attached patch patch v.1 (core) — — Splinter Review 

        Attachment #497631 -
        Flags: review?(jonas)

    
    

    
  

      
      
      
      

        Attached patch
          
          
        patch v.1 (tests) (obsolete)
        — 
          — Splinter Review
      

    


  

        Attachment #497632 -
        Flags: review?(jonas)

    
    

    
  
pushing to try.

    
    

    
  
ben, i can update your patch queue, or update m-c after you land.

    
  

        Attachment #497632 -
        Attachment is patch: true

        Attachment #497632 -
        Attachment mime type: application/octet-stream → text/plain

    
    

    
  


  

        Attachment #497632 -
        Attachment is obsolete: true

        Attachment #497883 -
        Flags: review?(jonas)

        Attachment #497632 -
        Flags: review?(jonas)

    
    

    
  
jst, can you review?
blocking2.0: --- → ?

    
    

    
  
s/review/review+approve.

    
    

    
  
http://hg.mozilla.org/mozilla-central/rev/ca0f807691f9
http://hg.mozilla.org/mozilla-central/rev/0aff32dee6a7
Status: NEW → RESOLVED
Closed: 13 years ago
Keywords: dev-doc-needed
Resolution: --- → FIXED

    
    

    
  
Docs refer to this as mozIndexedDB, so doc complete on this one.
Keywords: dev-doc-needed → dev-doc-complete
Component: DOM → DOM: IndexedDB

          You need to log in
          before you can comment on or make changes to this bug.